You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2018/01/08 13:56:37 UTC
[GitHub] spark pull request #20186: [SPARK-22990][Core] Fix method isFairScheduler in...
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/20186
[SPARK-22990][Core] Fix method isFairScheduler in JobsTab and StagesTab
## What changes were proposed in this pull request?
In current implementation, the function `isFairScheduler` is always false, since it is comparing String with `SchedulingMode`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark isFairScheduler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20186
----
commit 01c932f5929b6544b84eb700ab6e6d9a97f0eaf7
Author: Wang Gengliang <lt...@...>
Date: 2018-01-08T13:41:36Z
Fix isFairScheduler
commit fb87aa6b329310eb3695ceaaf26b93158dfe9635
Author: Wang Gengliang <lt...@...>
Date: 2018-01-08T13:49:47Z
better fix
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20186
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/20186
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20186: [SPARK-22990][Core] Fix method isFairScheduler in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20186
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20186
**[Test build #85800 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85800/testReport)** for PR 20186 at commit [`fb87aa6`](https://github.com/apache/spark/commit/fb87aa6b329310eb3695ceaaf26b93158dfe9635).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20186
Is it easy to add a unit test in `StagePageSuite`? Also this is the kind of stuff the compiler should be complaining about...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20186
I think it's fine. We usually don't test if a config can be correctly set as it's so trivial...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/20186
I just did a quick test with code changes, it works.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20186
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85801/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20186
thanks, merging to master/2.3!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20186
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20186
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85800/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20186
**[Test build #85804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85804/testReport)** for PR 20186 at commit [`10b5518`](https://github.com/apache/spark/commit/10b551851de532aeec78aa9c79f9cfac19155350).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20186
> I think it's fine. We usually don't test if a config can be correctly set as it's so trivial...
The point is to test that the code using that config works as expected, not that it can be set. And as this PR proves, code can be wrong even in "trivial" cases.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20186
good catch! LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20186
**[Test build #85801 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85801/testReport)** for PR 20186 at commit [`10b5518`](https://github.com/apache/spark/commit/10b551851de532aeec78aa9c79f9cfac19155350).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20186
**[Test build #85804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85804/testReport)** for PR 20186 at commit [`10b5518`](https://github.com/apache/spark/commit/10b551851de532aeec78aa9c79f9cfac19155350).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20186
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85804/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20186
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20186
**[Test build #85800 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85800/testReport)** for PR 20186 at commit [`fb87aa6`](https://github.com/apache/spark/commit/fb87aa6b329310eb3695ceaaf26b93158dfe9635).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20186: [SPARK-22990][Core] Fix method isFairScheduler in JobsTa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20186
**[Test build #85801 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85801/testReport)** for PR 20186 at commit [`10b5518`](https://github.com/apache/spark/commit/10b551851de532aeec78aa9c79f9cfac19155350).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org