[jira] [Commented] (TINKERPOP-1831) Refactor EventStrategy

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16504865#comment-16504865 ] 

ASF GitHub Bot commented on TINKERPOP-1831:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/872

    TINKERPOP-1831 Refactored EventStrategy

    https://issues.apache.org/jira/browse/TINKERPOP-1831
    
    Removed deprecated method. Used `VertexProperty.empty()` and `Property.empty()` to represent the "old" value for new property events. Created an enum for configuring detachment on the `EventStrategy` builder. Upgrade docs describe this change in more detail.
    
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1831

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #872
    
----
commit 7963fdfb4407347a37ff35d40f5efdd1ba5f039f
Author: Stephen Mallette <sp...@...>
Date:   2018-06-07T13:10:47Z

    TINKERPOP-1831 Refactored EventStrategy
    
    Removed deprecated method. Used VertexProperty.empty() and Property.empty() to represent the "old" value for new property events. Created a enum for configuring detachment on the EventStrategy builder.

----


> Refactor EventStrategy 
> -----------------------
>
>                 Key: TINKERPOP-1831
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1831
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: structure
>    Affects Versions: 3.2.6
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>              Labels: breaking
>             Fix For: 3.4.0
>
>
> {{EventStrategy}} has a few issues that could be smoothed out, but not without an allowance for breaking change in the API:
> * For the creation of new properties, an empty detached property is created to represent it - now that detachment is configurable, that doesn't always make sense. For example, if you configured for reference detachment then you would probably want a {{ReferenceProperty}} instead. Not sure how this should be resolved, but it probably needs a change to the eventing API itself
> * Detachment is configured a bit strangely with the use of {{null}} and passing classes for the appropriate detachment factories....would be nicer to have an interface to represent this stuff.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)