You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/07/24 00:21:51 UTC
[jira] Created: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
------------------------------------------------------------------------------------
Key: CASSANDRA-1313
URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7 beta 1
Reporter: Jonathan Ellis
Assignee: Jon Hermes
Fix For: 0.7 beta 1
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1313) make cache sizes in CfDef
Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Andrey Somov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896033#action_12896033 ]
Andrey Somov commented on CASSANDRA-1313:
-----------------------------------------
Jon, may I kindly ask you to clarify your decision ?
1) you requested to change SnakeYAML without clear message what other users (not only Cassandra) will gain from such a change
2) I have provided you with a solution (http://code.google.com/p/snakeyaml/source/browse/src/test/java/examples/CustomImplicitResolverTest.java) which you can copy-and-paste to your code with minimum effort. You did not give any feedback back to the SnakeYAML community (http://code.google.com/p/snakeyaml/issues/detail?id=75). Why the solution did not work ?
3) using YamlBeans does not actually solve your problem. As far as I can see you introduced "These getters/setters allow us to read X% in as a double". The same can be done with SnakeYAML
4) Be aware that SnakeYAML implements complete 1.1 YAML specification and it has many other unique features not available in YamlBeans.
I strongly believe that communication is the best way to quickly solve the issues. SnakeYAML is open for suggestions and we are glad to help others to use the library. But we also expect that the community explains the decision and help us to improve SnakeYAML where it needs to be improved.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1313) make cache sizes in CfDef
Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893419#action_12893419 ]
Matthew F. Dennis commented on CASSANDRA-1313:
----------------------------------------------
+1 on the approach. I'd like to see snakeyaml adopt this patch.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: 1313-SY.txt
snakeyaml-percentToFloat.txt
snakeyaml-r1131-dev.jar
Re-attaching snakeyaml approach.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: 1313.txt)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1313) make cache sizes in CfDef
Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898584#action_12898584 ]
Hudson commented on CASSANDRA-1313:
-----------------------------------
Integrated in Cassandra #514 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/514/])
add back percentage option for cache size configuration, and replace SnakeYAML with YamlBeans. patch by Jon Hermes; reviewed by jbellis for CASSANDRA-1313
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: snakeyaml-percentToFloat.txt
1313.txt
snakeyaml-r1131-dev1.jar
Simply making \{rows,keys\}_cached strings instead of doubles is problematic. The current code looks for 'double \{rows,keys\}_cached', and changing every lookup is a non-trivial chunk of code. The lookup would also take extra cycles (or just two extra cycles if the first lookups cache the String->Double operation).
Loading a String into a Double from the YAML using snakeyaml directly has proven difficult:
* Getters and setters on the Config/RawKS/RawCF beans are never called, so there is no immediate hook.
* Telling the constructor in DD that "50%" should be a double does not help the constructor parse the string into a double -- snakeyaml explodes.
* Pushing the values into a String on the bean, then populating the double from the string leaves extra variables around. Also, these extra variables have to be named something different than \{rows,keys\}_cached, which means extra work in our 0.6->0.7 Converter.
* Pushing the values into a String on a FooConfig, then generating Config from FooConfig works, but means two passes on the load and hard to maintain later.
* *Finally,* change the snakeyaml code directly. Whenever it sees a number followed by a percent, it should correctly construct a FloatType (be it Float, Double, or BigDecimal according to destination).
I decided the best fix is to effect a change in snakeyaml as outlined above (and tracked at: http://code.google.com/p/snakeyaml/issues/detail?id=75 ).
Attached are 3 things:
- The patch to snakeyaml trunk, named snakeyaml-percentToFloat.txt,
- The lib built from trunk after patch applied, named snakeyaml-r1131-dev1.jar,
- and a patch for C trunk (changes conf/cassandra.yaml and test/conf/cassandra.yaml), named 1313.txt.
With this, the values legal for \{rows,keys\}_cached is a literal (1000, 0.5, 0) or a string ("1000", "50%", "0%"). As before, a value between [0,1] is a fraction of the total, and all larger values are absolute. Because this is a change to the parser, you can also give percents anywhere else a double is expected (read_repair_chance: '72.25%' if you want).
Should this change not be accepted, one of the above methods can be employed in our code, or I can override-in all the functionality of the patch (though the code will look like a trainwreck).
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1313:
--------------------------------------
Description: (note, this was reverted for 0.7 in CASSANDRA-1394)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
> (note, this was reverted for 0.7 in CASSANDRA-1394)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: snakeyaml-percentToFloat.txt)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1313) make cache sizes in CfDef
Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896076#action_12896076 ]
Jon Hermes commented on CASSANDRA-1313:
---------------------------------------
1) I've made it painfully clear why I offered the patch to the community.
2) I have many good solutions now. This has been a solved problem for a while. There is a reason why snakeyaml-75 is marked as an Enhancement, not a Bug.
3,4) Switching to YamlBeans was not because I couldn't solve the problem without it, but because the code is much easier to read, smaller, and removed many lines of our code.
If you still desire clarification, feel free to e-mail me. Unless there are complications on this defect, I'm considering it finished and moving on to other things. As for snakeyaml-75, I'm leaving it open to be closed as Invalid at your discretion.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: snakeyaml-percentToFloat.txt)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1313:
--------------------------------------
Priority: Minor (was: Major)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.7 beta 2
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: snakeyaml-output.patch
Attached debugging patch to print the values of \{rows,keys\}_cached to STDOUT when the config is first loaded.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: 1313-YB.txt)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1313) make cache sizes in CfDef
Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Andrey Somov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894062#action_12894062 ]
Andrey Somov commented on CASSANDRA-1313:
-----------------------------------------
You do not need to patch SnakeYAML to achieve the goal. SnakeYAML has the following feature: any scalar which matches a given regular expression can be constructed with some custom code.
Examples can be found in the tests.
We shall think twice before we patch SnakeYAML. Appending '%' to a number is not a common pattern. It is not part of the YAML specification. Other users may be confused when they get Float when they expect String
-
Andrey
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: snakeyaml-r1131-dev1.jar)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1313:
--------------------------------------
Fix Version/s: 0.7.0
(was: 0.7 beta 1)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-1313) make cache sizes in
CfDef Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893384#action_12893384 ]
Jon Hermes edited comment on CASSANDRA-1313 at 7/28/10 5:57 PM:
----------------------------------------------------------------
Attached debugging patch to print the values of \{rows,keys\}_cached to STDOUT when the config is first loaded.
Named snakeyaml-output.patch.
was (Author: jhermes):
Attached debugging patch to print the values of \{rows,keys\}_cached to STDOUT when the config is first loaded.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: snakeyaml-output.patch)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: (was: snakeyaml-r1131-dev1.jar)
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: 1313-YB.txt
yamlbeans-1.04.jar
Replacing snakeyaml with yamlbeans.
Status:
M conf/cassandra.yaml
D src/java/org/apache/cassandra/utils/SkipNullRepresenter.java
M src/java/org/apache/cassandra/tools/NodeProbe.java
M src/java/org/apache/cassandra/tools/SchemaTool.java
M src/java/org/apache/cassandra/service/StorageService.java
M src/java/org/apache/cassandra/service/StorageServiceMBean.java
M src/java/org/apache/cassandra/config/DatabaseDescriptor.java
M src/java/org/apache/cassandra/config/Config.java
M src/java/org/apache/cassandra/config/Converter.java
M src/java/org/apache/cassandra/config/RawColumnFamily.java
M NOTICE.txt
D lib/snakeyaml-1.6.jar
A lib/yamlbeans-1.04.jar
Reading the config and loading keyspaces works properly.
Exporting keyspaces (using schematool) works properly given a target output file.
Converting from 0.6 to 0.7 has no diff from using snakeyaml.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313-YB.txt, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: 1313-YB.txt
And lastly fixing 1313-YB.txt to remove debug statements.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7.0
>
> Attachments: 1313-SY.txt, 1313-YB.txt, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev.jar, yamlbeans-1.04.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1313) make cache sizes in CfDef Strings
again so we can use %s of rows in the CF as in 0.6
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-1313:
----------------------------------
Attachment: snakeyaml-percentToFloat.txt
snakeyaml-r1131-dev1.jar
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1313) make cache sizes in CfDef
Strings again so we can use %s of rows in the CF as in 0.6
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893484#action_12893484 ]
Jonathan Ellis commented on CASSANDRA-1313:
-------------------------------------------
I like this, too. Nice work.
> make cache sizes in CfDef Strings again so we can use %s of rows in the CF as in 0.6
> ------------------------------------------------------------------------------------
>
> Key: CASSANDRA-1313
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1313
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Jonathan Ellis
> Assignee: Jon Hermes
> Fix For: 0.7 beta 1
>
> Attachments: 1313.txt, snakeyaml-output.patch, snakeyaml-percentToFloat.txt, snakeyaml-r1131-dev1.jar
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.