[GitHub] [cordova-android] raphinesse commented on a change in pull request #709: Support SDK versions with pre-release identifiers

[GitBox <gi...@apache.org>]

raphinesse commented on a change in pull request #709: Support SDK versions with pre-release identifiers
URL: https://github.com/apache/cordova-android/pull/709#discussion_r271461661
 
 

 ##########
 File path: framework/cordova.gradle
 ##########
 @@ -78,19 +78,26 @@ int compareVersionList(Collection aParts, Collection bParts) {
     pairs.findResult(aParts.size()-bParts.size()) {it[0] - it[1] != 0 ? it[0] - it[1] : null}
 }
 
-// Compare two version strings, such as "19.0.0" and "18.1.1.0". If all matched
+// Compare two version strings, such as "19.0.0-rc1" and "18.1.1.0". If all matched
 // elements are identical, the longer version is the largest by this method.
 // Examples:
+//   "20.0.0-rc1" > "19.0.0"
 //   "19.0.0" > "19"
 //   "19.0.1" > "19.0.0"
 //   "19.1.0" > "19.0.1"
 //   "19" > "18.999.999"
 int compareVersions(String a, String b) {
+    a = removeTagOfReleaseLifeCycle(a)
+    b = removeTagOfReleaseLifeCycle(b)
 
 Review comment:
   Nice! Thanks for giving this another go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org