[GitHub] [lucene] jtibshirani commented on a change in pull request #176: LUCENE-9905: Make sure to use configured vector format when merging

[GitBox <gi...@apache.org>]

jtibshirani commented on a change in pull request #176:
URL: https://github.com/apache/lucene/pull/176#discussion_r647045642



##########
File path: lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldVectorFormat.java
##########
@@ -114,14 +114,7 @@ public void close() throws IOException {
     }
 
     private VectorWriter getInstance(FieldInfo field) throws IOException {
-      VectorFormat format = null;

Review comment:
       I think the original logic was copied from `PerFieldDocValuesFormat`. My understanding is that it is *not* meant to be applied during merging (and `PerFieldPostingsFormat` doesn't even include it). I'd appreciate if someone could double-check this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org