You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/05/22 10:32:04 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #25851: Fix sonar issue: Remove Optional null check in ResultIterator
sandynz opened a new pull request, #25851:
URL: https://github.com/apache/shardingsphere/pull/25851
Changes proposed in this pull request:
- Fix sonar issue: Remove Optional null check in ResultIterator
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #25851: Fix sonar issue: Remove Optional null check in ResultIterator
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on code in PR #25851:
URL: https://github.com/apache/shardingsphere/pull/25851#discussion_r1200371985
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/AbstractStreamingDataConsistencyCalculateAlgorithm.java:
##########
Review Comment:
Ci failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #25851: Fix sonar issue: Remove Optional null check in ResultIterator
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on code in PR #25851:
URL: https://github.com/apache/shardingsphere/pull/25851#discussion_r1201425698
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/AbstractStreamingDataConsistencyCalculateAlgorithm.java:
##########
Review Comment:
There's random error in infra module and pipeline e2e, it works after rerun. We need to check it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy merged pull request #25851: Fix sonar issue: Remove Optional null check in ResultIterator
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy merged PR #25851:
URL: https://github.com/apache/shardingsphere/pull/25851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #25851: Fix sonar issue: Remove Optional null check in ResultIterator
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on code in PR #25851:
URL: https://github.com/apache/shardingsphere/pull/25851#discussion_r1200370242
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/AbstractStreamingDataConsistencyCalculateAlgorithm.java:
##########
@@ -65,6 +66,8 @@ public Iterator<DataConsistencyCalculatedResult> iterator() {
@RequiredArgsConstructor
Review Comment:
ci failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] azexcy commented on a diff in pull request #25851: Fix sonar issue: Remove Optional null check in ResultIterator
Posted by "azexcy (via GitHub)" <gi...@apache.org>.
azexcy commented on code in PR #25851:
URL: https://github.com/apache/shardingsphere/pull/25851#discussion_r1200371106
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/AbstractStreamingDataConsistencyCalculateAlgorithm.java:
##########
Review Comment:
Ci failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org