[GitHub] [incubator-superset] DiggidyDave commented on a change in pull request #7536: Add link to scheduled pipeline

[GitBox <gi...@apache.org>]

DiggidyDave commented on a change in pull request #7536: Add link to scheduled pipeline
URL: https://github.com/apache/incubator-superset/pull/7536#discussion_r285209476
 
 

 ##########
 File path: docs/installation.rst
 ##########
 @@ -906,6 +906,12 @@ To allow scheduled queries, add the following to your `config.py`:
                     'container': 'end_date',
                 },
             ],
+            # link to the scheduler; this example links to an Airflow pipeline
+            # that uses the query id and the output table as its name
+            'linkback': (
 
 Review comment:
   Is this not a circular dependency?  Superset should not know anything about the scheduler (eg Airflow), should it? The scheduler knows about superset, and grabs work from a known endpoint, and neither the user nor superset system itself should actually care who is doing that work.
   
   I think we should consider letting any arbitrary scheduler  PUT back information (like a URL) about how to view it pipelines or whatever representation it uses for the work it is doing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org