You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/07/14 02:22:40 UTC
[GitHub] [lucene] rmuir opened a new pull request #211: LUCENE-5595: re-enable TestICUNormalizer2CharFilter random test, splitting by mode
rmuir opened a new pull request #211:
URL: https://github.com/apache/lucene/pull/211
Re-enable the randomized testing here, but with a separate test for each
mode rather than all in one method. It gives better testing and also easier-to-debug
testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #211: LUCENE-5595: re-enable TestICUNormalizer2CharFilter random test, splitting by mode
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #211:
URL: https://github.com/apache/lucene/pull/211#issuecomment-879535535
cc: @magibney
This is the basic random test that we've had disabled for years. Honestly original bugs could have been in ICU itself, not sure. Maybe the new tests will fail! But I think it is much better for us to enable it in `main` branch with the new gradle build, with tests corresponding to different normalization modes. Maybe we stand a better chance to fix any failures this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] magibney commented on pull request #211: LUCENE-5595: re-enable TestICUNormalizer2CharFilter random test, splitting by mode
Posted by GitBox <gi...@apache.org>.
magibney commented on pull request #211:
URL: https://github.com/apache/lucene/pull/211#issuecomment-879538390
LGTM; makes sense to re-enable and add separate tests for different normalization forms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #211: LUCENE-5595: re-enable TestICUNormalizer2CharFilter random test, splitting by mode
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #211:
URL: https://github.com/apache/lucene/pull/211#issuecomment-879540243
I'm running my inefficient beasting script: shell script loop, gradle daemons disabled, all lucene/analysis/icu tests with nightly and multiplier. I'll let it run for a while before we try jenkins, I don't want to just make builds flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #211: LUCENE-5595: re-enable TestICUNormalizer2CharFilter random test, splitting by mode
Posted by GitBox <gi...@apache.org>.
rmuir commented on pull request #211:
URL: https://github.com/apache/lucene/pull/211#issuecomment-879551134
100 successful runs in beasting with nightly and 10x multiplier: I think we are ok. Can always open an issue if jenkins trips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #211: LUCENE-5595: re-enable TestICUNormalizer2CharFilter random test, splitting by mode
Posted by GitBox <gi...@apache.org>.
rmuir merged pull request #211:
URL: https://github.com/apache/lucene/pull/211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org