You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/23 01:13:21 UTC
[GitHub] [tvm] pratikfegade opened a new issue #7724: Minor bug in storage_access.cc
pratikfegade opened a new issue #7724:
URL: https://github.com/apache/tvm/issues/7724
Hi,
I have been playing around with TVM and it seems that the barrier insertion pass (implemented in `src/tir/storage_access.cc` and `src/tir/thread_storage_sync.cc`) does not handle the else case of an `IfThenElse` node correctly. Specifically, I think the body of the else case, when present, is not being visited in the code [here](https://github.com/apache/tvm/blob/main/src/tir/transforms/storage_access.cc#L177).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #7724: Minor bug in storage_access.cc
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #7724:
URL: https://github.com/apache/tvm/issues/7724#issuecomment-804511979
thanks @pratikfegade, great catch can you craft a regression test case and send a patch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi closed issue #7724: Minor bug in storage_access.cc
Posted by GitBox <gi...@apache.org>.
masahi closed issue #7724:
URL: https://github.com/apache/tvm/issues/7724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #7724: Minor bug in storage_access.cc
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #7724:
URL: https://github.com/apache/tvm/issues/7724#issuecomment-883666742
cc @masahi it would be great if you can help follow up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org