You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/02 07:53:21 UTC

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #1694: arch, include, sched : Refactor ARCH_GLOBAL_IRQDISABLE related code

masayuki2009 opened a new pull request #1694:
URL: https://github.com/apache/incubator-nuttx/pull/1694


   ## Summary
   
   - ARCH_GLOBAL_IRQDISABLE was initially introduced for LC823450 SMP
   - At that time, i.MX6 (quad Cortex-A9) did not use this config
   - However, this option is now used for all CPUs which support SMP
   - So it's good timing for refactoring the code
   
   ## Impact
   
   - Should have no impact because the logic is the same for SMP
   
   ## Testing
   
   - Tested with board: spresense:smp, spresense:wifi_smp
   - Tested with qemu: esp32-core:smp, maix-bit:smp, sabre-6quad:smp
   - Build only: lc823450-xgevk:rndis, sam4cmp-db:nsh
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1694: arch, include, sched : Refactor ARCH_GLOBAL_IRQDISABLE related code

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1694:
URL: https://github.com/apache/incubator-nuttx/pull/1694#issuecomment-685440072


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1694: arch, include, sched : Refactor ARCH_GLOBAL_IRQDISABLE related code

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1694:
URL: https://github.com/apache/incubator-nuttx/pull/1694#issuecomment-685437961


   LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1694: arch, include, sched : Refactor ARCH_GLOBAL_IRQDISABLE related code

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1694:
URL: https://github.com/apache/incubator-nuttx/pull/1694#issuecomment-685424989


   Hi @patacongo,
   
   I've just refactored ARCH_GLOBAL_IRQDISABLE related code.
   Because the config is used for all CPUs which support SMP.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1694: arch, include, sched : Refactor ARCH_GLOBAL_IRQDISABLE related code

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1694:
URL: https://github.com/apache/incubator-nuttx/pull/1694


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org