[GitHub] [ozone] adoroszlai commented on a diff in pull request #4205: HDDS-7826. Add support for application to probe output stream capability

["adoroszlai (via GitHub)" <gi...@apache.org>]

adoroszlai commented on code in PR #4205:
URL: https://github.com/apache/ozone/pull/4205#discussion_r1092955665


##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/OzoneStreamCapabilities.java:
##########
@@ -44,4 +44,8 @@ private OzoneStreamCapabilities() {
    * TODO: If Hadoop dependency is upgraded, this string can be removed.
    */
   static final String UNBUFFER = "in:unbuffer";
+
+  static final String HSYNC = "hsync";
+
+  static final String HFLUSH = "hflush";

Review Comment:
   Only if you update the patch anyway:
   
   I think we can use these constants from Hadoop's `StreamCapabilities` directly.  `OzoneStreamCapabilities` was added when Ozone used Hadoop 3.2, which didn't have the other two constants.  (This reminds me to address the TODO above, filed HDDS-7863 for that.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org