You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by so...@apache.org on 2017/12/02 09:01:34 UTC
openmeetings git commit: [OPENMEETINGS-1721] couple sonar issues are
addressed
Repository: openmeetings
Updated Branches:
refs/heads/master 08c09833b -> 464bd1d17
[OPENMEETINGS-1721] couple sonar issues are addressed
Project: http://git-wip-us.apache.org/repos/asf/openmeetings/repo
Commit: http://git-wip-us.apache.org/repos/asf/openmeetings/commit/464bd1d1
Tree: http://git-wip-us.apache.org/repos/asf/openmeetings/tree/464bd1d1
Diff: http://git-wip-us.apache.org/repos/asf/openmeetings/diff/464bd1d1
Branch: refs/heads/master
Commit: 464bd1d17a3750d4e5839cc8c4bbad7cd2e9787e
Parents: 08c0983
Author: Maxim Solodovnik <so...@gmail.com>
Authored: Sat Dec 2 16:01:27 2017 +0700
Committer: Maxim Solodovnik <so...@gmail.com>
Committed: Sat Dec 2 16:01:27 2017 +0700
----------------------------------------------------------------------
.../apache/openmeetings/web/user/chat/ChatToolbar.java | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/openmeetings/blob/464bd1d1/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatToolbar.java
----------------------------------------------------------------------
diff --git a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatToolbar.java b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatToolbar.java
index e387238..92a5c40 100644
--- a/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatToolbar.java
+++ b/openmeetings-web/src/main/java/org/apache/openmeetings/web/user/chat/ChatToolbar.java
@@ -65,9 +65,9 @@ public class ChatToolbar extends Panel implements IWysiwygToolbar {
private ConfirmableAjaxBorder delBtn;
private final AjaxDownloadBehavior download = new AjaxDownloadBehavior(new ResourceStreamResource() {
private static final long serialVersionUID = 1L;
- private static final char delimiter = ',';
- private static final char quoteCharacter = '"';
- private final String quoteReplacement = new StringBuilder().append(quoteCharacter).append(quoteCharacter).toString();
+ private static final char DELIMITER = ',';
+ private static final char QUOTE_CHAR = '"';
+ private final String quoteReplacement = new StringBuilder().append(QUOTE_CHAR).append(QUOTE_CHAR).toString();
{
setCacheDuration(NONE);
@@ -92,15 +92,15 @@ public class ChatToolbar extends Panel implements IWysiwygToolbar {
}
private StringBuilder appendQuoted(StringBuilder sb, String value) {
- return sb.append(quoteCharacter).append(value == null ? "" : value.replace(String.valueOf(quoteCharacter), quoteReplacement)).append(quoteCharacter);
+ return sb.append(QUOTE_CHAR).append(value == null ? "" : value.replace(String.valueOf(QUOTE_CHAR), quoteReplacement)).append(QUOTE_CHAR);
}
private void export(List<ChatMessage> list, StringBuilder sb) {
String lineDelim = "";
for (ChatMessage msg : list) {
sb.append(lineDelim);
- appendQuoted(sb, getName(msg.getFromUser())).append(delimiter);
- appendQuoted(sb, getDateFormat().format(msg.getSent())).append(delimiter);
+ appendQuoted(sb, getName(msg.getFromUser())).append(DELIMITER);
+ appendQuoted(sb, getDateFormat().format(msg.getSent())).append(DELIMITER);
appendQuoted(sb, msg.getMessage());
lineDelim = "\r\n";
}