You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2011/07/30 00:11:09 UTC
[jira] [Created] (PIG-2196) Test harness should be independent of
Pig
Test harness should be independent of Pig
-----------------------------------------
Key: PIG-2196
URL: https://issues.apache.org/jira/browse/PIG-2196
Project: Pig
Issue Type: Improvement
Affects Versions: 0.10
Reporter: Ashutosh Chauhan
Assignee: Ashutosh Chauhan
Fix For: 0.10
Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Attachment: pig-2196.patch
clean up test/e2e/pig/harness so that it doesn't make those assumptions.
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Status: Patch Available (was: Reopened)
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196-remaining.patch, pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2196) Test harness should be independent of
Pig
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087830#comment-13087830 ]
Alan Gates commented on PIG-2196:
---------------------------------
So this patch isn't what made the ant above fail. It turns out I had built the wrong parts of Pig. However, there are times we need to know where the Hadoop executable (bin/hadoop) is. Currently we use pig.harness.cluster/conf to find the configuration file and pig.harness.cluster/bin to find the executable. As Ashutosh pointed pointed out with packaging changes this path structure assumption will not always be valid. Instead we should have two separate properties, one that points to the conf directory and one that points to the executable.
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan reopened PIG-2196:
-----------------------------------
Renaming files in svn repo is always fraught with troubles. Few changes missed in test_harness.pl
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196-remaining.patch, pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch checked-in. I am sure there are other traces of pig in there which will remind of pig in the harness : )
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch checked-in.
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196-remaining.patch, pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2196) Test harness should be independent of
Pig
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083778#comment-13083778 ]
Alan Gates commented on PIG-2196:
---------------------------------
In default.conf, changing the default of testconfigpath from $ENV{PH_CLUSTER}/conf to $ENV/{PH_CLUSTER} breaks the tests. Without the patch 'ant -Dpig.harness.old.pig=$HOME/grid/pig-0.8.1/ -Dpig.harness.cluster=$HOME/grid/max' works, but with the patch it fails.
Also, why not change the names from pig.harness.old.pig and pig.harness.cluster to harness.old.pig and harness.cluster, since you're trying to remove the piggyness from the harness?
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Attachment: pig-2196_1.patch
Updated patch with Alan's comments.
1. Split PH_CLUSTER into PH_CLUSTER_BIN and PH_CLUSTER_CONF to separate conf and bin locations.
2. Renamed harness.cluster and harness.old.pig
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Status: Patch Available (was: Open)
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2196) Test harness should be independent of
Pig
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated PIG-2196:
----------------------------------
Attachment: pig-2196-remaining.patch
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196-remaining.patch, pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2196) Test harness should be independent of
Pig
Posted by "Alan Gates (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087973#comment-13087973 ]
Alan Gates commented on PIG-2196:
---------------------------------
+1, changes look good. We should have changed the name to guinea pig instead of removing pig :)
> Test harness should be independent of Pig
> -----------------------------------------
>
> Key: PIG-2196
> URL: https://issues.apache.org/jira/browse/PIG-2196
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.10
> Reporter: Ashutosh Chauhan
> Assignee: Ashutosh Chauhan
> Fix For: 0.10
>
> Attachments: pig-2196.patch, pig-2196_1.patch
>
>
> Test harness is designed to be independent of Pig, but currently it makes those assumptions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira