You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/29 10:54:14 UTC
[GitHub] [incubator-kyuubi] turboFei opened a new pull request, #2518: [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
turboFei opened a new pull request, #2518:
URL: https://github.com/apache/incubator-kyuubi/pull/2518
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2518: [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2518:
URL: https://github.com/apache/incubator-kyuubi/pull/2518#discussion_r861745317
##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiBeeLine.java:
##########
@@ -162,15 +162,7 @@ int initArgs(String[] args) {
int code = 0;
if (cl.getOptionValues('e') != null) {
commands = Arrays.asList(cl.getOptionValues('e'));
- try {
- Field optsField = BeeLine.class.getDeclaredField("opts");
- optsField.setAccessible(true);
- BeeLineOpts opts = (BeeLineOpts) optsField.get(this);
- opts.setAllowMultiLineCommand(false);
- } catch (Exception t) {
- error(t.getMessage());
- return 1;
- }
+ getOpts().setAllowMultiLineCommand(false); // When using -e, command is always a single line
Review Comment:
How about putting a Hive JIRA ticket ID here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2518: [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2518:
URL: https://github.com/apache/incubator-kyuubi/pull/2518#issuecomment-1113297511
```HiveEventLoggingServiceSuite:
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/runner/.m2/repository/org/apache/logging/log4j/log4j-slf4j-impl/2.17.2/log4j-slf4j-impl-2.17.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/runner/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
- test engine event logging !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEventLoggingServiceSuite.scala:63)
- test session event logging !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEventLoggingServiceSuite.scala:83)
- test operation event logging !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEventLoggingServiceSuite.scala:103)
HiveOperationSuite:
- get catalogs !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:36)
- get schemas !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:44)
- get tables !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:67)
- get columns !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:135)
- get functions !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:210)
- get table types !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:229)
- get primary keys !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:244)
- get cross reference !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:269)
- basic execute statements, create, insert query !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:316)
- test getTypeInfo !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:334)
- test setClientInfo !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveEngineTests.scala:432)
- test get query id !!! CANCELED !!!
org.apache.commons.lang3.SystemUtils.isJavaVersionAtMost(JAVA_1_8) was false (HiveOperationSuite.scala:44)
- test set command *** FAILED ***
org.apache.thrift.protocol.TProtocolException: Required field 'sessionHandle' is unset! Struct:TExecuteStatementReq(sessionHandle:null, statement:set hive.query.name=test, runAsync:true)
at org.apache.hive.service.rpc.thrift.TExecuteStatementReq.validate(TExecuteStatementReq.java:629)
at org.apache.hive.service.rpc.thrift.TCLIService$ExecuteStatement_args.validate(TCLIService.java:5591)
at org.apache.hive.service.rpc.thrift.TCLIService$ExecuteStatement_args$ExecuteStatement_argsStandardScheme.write(TCLIService.java:5648)
at org.apache.hive.service.rpc.thrift.TCLIService$ExecuteStatement_args$ExecuteStatement_argsStandardScheme.write(TCLIService.java:5617)
at org.apache.hive.service.rpc.thrift.TCLIService$ExecuteStatement_args.write(TCLIService.java:5568)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:71)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:62)
at org.apache.hive.service.rpc.thrift.TCLIService$Client.send_ExecuteStatement(TCLIService.java:239)
at org.apache.hive.service.rpc.thrift.TCLIService$Client.ExecuteStatement(TCLIService.java:231)
at org.apache.kyuubi.engine.hive.operation.HiveOperationSuite.$anonfun$new$4(HiveOperationSuite.scala:60)
...
Run completed in 4 seconds, 861 milliseconds.
Total number of tests run: 1
Suites: completed 3, aborted 0
Tests: succeeded 0, failed 1, canceled 15, ignored 0, pending 0
*** 1 TEST FAILED ***
Error: Failed to execute goal org.scalatest:scalatest-maven-plugin:2.0.2:test (test) on project kyuubi-hive-sql-engine_2.12: There are test failures -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.scalatest:scalatest-maven-plugin:2.0.2:test (test) on project kyuubi-hive-sql-engine_2.12: There are test failures
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:306)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:211)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:165)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:157)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:121)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:127)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures
at org.scalatest.tools.maven.TestMojo.execute (TestMojo.java:109)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:301)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:211)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:165)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:157)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:121)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:127)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:566)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #2518: [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #2518: [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
URL: https://github.com/apache/incubator-kyuubi/pull/2518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2518: [KYUUBI #2478][FOLLOWUP] Invoke getOpts method instead of Reflection
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2518:
URL: https://github.com/apache/incubator-kyuubi/pull/2518#issuecomment-1113447259
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org