You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@struts.apache.org by "lukaszlenart (via GitHub)" <gi...@apache.org> on 2026/08/30 15:14:16 UTC

[PR] docs: point CLAUDE.md at THREAT_MODEL.md for security scope [struts]

lukaszlenart opened a new pull request, #1885:
URL: https://github.com/apache/struts/pull/1885

   The **Security Reports & Scans** section of `CLAUDE.md` named [`SECURITY.md`](SECURITY.md) and [`AGENTS.md`](AGENTS.md) but not [`THREAT_MODEL.md`](THREAT_MODEL.md). Anything working from `CLAUDE.md` alone therefore reached the *reporting process* without the *scope* that decides whether there is anything to report — `THREAT_MODEL.md` was only reachable transitively, through a link in `SECURITY.md:8` or `AGENTS.md:17`.
   
   This matters most for automated review. A generic security pass over a Struts diff will confidently flag unannotated setters, direct JSP access, raw `${}` EL and "generic DoS" — every one of which `THREAT_MODEL.md` §11a already closes as a known non-finding, and §13 routes to `OUT-OF-MODEL: application-responsibility` or `non-default-config`.
   
   So name the file directly and say what it is for.
   
   Documentation only — no ticket, per the `docs:` convention in `CLAUDE.md`. No code, build or CI files touched.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   
   https://claude.ai/code/session_01AtyHU8BzNmeZNncXRu7yjB


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: point CLAUDE.md at THREAT_MODEL.md for security scope [struts]

Posted by "lukaszlenart (via GitHub)" <gi...@apache.org>.
lukaszlenart merged PR #1885:
URL: https://github.com/apache/struts/pull/1885


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: point CLAUDE.md at THREAT_MODEL.md for security scope [struts]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #1885:
URL: https://github.com/apache/struts/pull/1885#issuecomment-5469528990

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1885) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_struts&pullRequest=1885&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_struts&pullRequest=1885&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1885&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_struts&pullRequest=1885&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_struts&pullRequest=1885)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org