You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by "kiddkaffeine (via GitHub)" <gi...@apache.org> on 2023/03/03 04:03:12 UTC
[GitHub] [poi] kiddkaffeine opened a new pull request, #436: Add flag for Excel 4 macros in composite documents
kiddkaffeine opened a new pull request, #436:
URL: https://github.com/apache/poi/pull/436
This includes a composite (non-OOXML) Excel document with a Excel 4 macro. In the pre-OOXML world, these macros are binary and I'm not sure how to handle them, so this just marks their presence. (In OOXML, they're stored as text, but that come will later.)
Not sure how to unit test this without using EventFactory, am open to suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[GitHub] [poi] pjfanning commented on pull request #436: Add flag for Excel 4 macros in composite documents
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #436:
URL: https://github.com/apache/poi/pull/436#issuecomment-1474554346
I added this but then reverted it due to https://github.com/apache/poi/actions/runs/4452719179/jobs/7820620683
Causes issues like this:
```
Caused by: java.lang.IllegalStateException: bad function index (54, false)
at org.apache.poi.ss.formula.ptg.AbstractFunctionPtg.lookupName(AbstractFunctionPtg.java:143)
at org.apache.poi.ss.formula.ptg.FuncVarPtg.lookupName(FuncVarPtg.java:82)
at org.apache.poi.ss.formula.ptg.AbstractFunctionPtg.getName(AbstractFunctionPtg.java:72)
at org.apache.poi.ss.formula.ptg.AbstractFunctionPtg.toFormulaString(AbstractFunctionPtg.java:95)
at org.apache.poi.ss.formula.FormulaRenderer.toFormulaString(FormulaRenderer.java:99)
at org.apache.poi.hssf.model.HSSFFormulaParser.toFormulaString(HSSFFormulaParser.java:89)
at org.apache.poi.hssf.usermodel.HSSFCell.getCellFormula(HSSFCell.java:643)
at org.apache.poi.hssf.usermodel.HSSFCell.toString(HSSFCell.java:1045)
at org.apache.poi.stress.SpreadsheetHandler.readContent(SpreadsheetHandler.java:84)
at org.apache.poi.stress.SpreadsheetHandler.handleWorkbook(SpreadsheetHandler.java:38)
at org.apache.poi.stress.HSSFFileHandler.handleFile(HSSFFileHandler.java:43)
at org.apache.poi.stress.TestAllFiles.lambda$handleFile$1(TestAllFiles.java:209)
at org.junit.jupiter.api.AssertDoesNotThrow.assertDoesNotThrow(AssertDoesNotThrow.java:49)
... 41 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [PR] Add flag for Excel 4 macros in composite documents [poi]
Posted by "kiddkaffeine (via GitHub)" <gi...@apache.org>.
kiddkaffeine closed pull request #436: Add flag for Excel 4 macros in composite documents
URL: https://github.com/apache/poi/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org