You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/04 11:18:49 UTC
[GitHub] [shardingsphere] Lucas-307 opened a new pull request #6617: rename ResumablePositionManager to ResumeBreakPointManager
Lucas-307 opened a new pull request #6617:
URL: https://github.com/apache/shardingsphere/pull/6617
rename ResumablePositionManager to ResumeBreakPointManager
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #6617: rename ResumablePositionManager to ResumeBreakPointManager
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #6617:
URL: https://github.com/apache/shardingsphere/pull/6617#discussion_r465143149
##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/config/ScalingContext.java
##########
@@ -57,5 +57,5 @@ public void init(final ServerConfiguration serverConfiguration) {
this.taskExecuteEngine = new ShardingScalingExecuteEngine(serverConfiguration.getWorkerThread());
this.importerExecuteEngine = new ShardingScalingExecuteEngine(serverConfiguration.getWorkerThread());
}
-
+
Review comment:
Please remove useless blank line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #6617: rename ResumablePositionManager to ResumeBreakPointManager
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6617:
URL: https://github.com/apache/shardingsphere/pull/6617
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Lucas-307 commented on a change in pull request #6617: rename ResumablePositionManager to ResumeBreakPointManager
Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on a change in pull request #6617:
URL: https://github.com/apache/shardingsphere/pull/6617#discussion_r465488287
##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/config/ScalingContext.java
##########
@@ -57,5 +57,5 @@ public void init(final ServerConfiguration serverConfiguration) {
this.taskExecuteEngine = new ShardingScalingExecuteEngine(serverConfiguration.getWorkerThread());
this.importerExecuteEngine = new ShardingScalingExecuteEngine(serverConfiguration.getWorkerThread());
}
-
+
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org