You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/11/19 10:02:26 UTC

[GitHub] storm pull request #2427: MINOR: Use booleans instead of strings for 'enable...

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2427

    MINOR: Use booleans instead of strings for 'enable.auto.commit' setting

    Kafka understands booleans in this property just fine, there's no reason to use strings instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm use-bool-instead-of-string

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2427
    
----
commit 774928028f2d06af5d68e13f0fb745561c2aa4a0
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-11-19T10:00:37Z

    MINOR: Use booleans instead of strings for 'enable.auto.commit' setting

----


---

[GitHub] storm pull request #2427: MINOR: Use booleans instead of strings for 'enable...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2427


---

[GitHub] storm issue #2427: MINOR: Use booleans instead of strings for 'enable.auto.c...

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2427
  
    Thanks, applied to master and 1.x


---

[GitHub] storm issue #2427: MINOR: Use booleans instead of strings for 'enable.auto.c...

Posted by hmcl <gi...@git.apache.org>.

Github user hmcl commented on the issue:

    https://github.com/apache/storm/pull/2427
  
    +1


---