[jira] [Commented] (OAK-2751) Test failures with EnableConcurrentAddRemove feature enabled on 1.0 branch

["Vikas Saurabh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14496186#comment-14496186 ] 

Vikas Saurabh commented on OAK-2751:
------------------------------------

In 1.0 branch with {{addRemoveSetMoveCopy(org.apache.jackrabbit.mk.test.RandomizedTest)}} fails if {{enableConcurrentAddDelete}} is set (see OAK-2673). The step that fails is attempting setting a property on a deleted node. This is an expected failure -- but it doesn't with current fix of OAK-2673.

-The reason the test passes on trunk is that trunk is using {{NodeStoreKernel.applyJsop}} which itself throws the exception while trying to set a property on an unavailable node.- This piece of code doesn't exist anymore on trunk ... it was roughly 1 week back (I believe it's due to removing MicroKernel implementation effort).

While fixing jsop parsing on 1.0 can fix the error, I belive, the fix should really be done in {{NodeDocument.isConflicting}} i.e. setting a property on a known deleted node should be called out as conflict.

[~mreutegg], thoughts?

> Test failures with EnableConcurrentAddRemove feature enabled on 1.0 branch
> --------------------------------------------------------------------------
>
>                 Key: OAK-2751
>                 URL: https://issues.apache.org/jira/browse/OAK-2751
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.0.13
>
>
> With merge of OAK-2673 some failures were seen in oak-it/mk which are not seen on trunk. This require further change in patch to shutdown the feature completely. 
> We still need to investigate why this happened and ensure that test pass with this feature enabled



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)