[GitHub] [incubator-mxnet] leezu commented on a change in pull request #19596: Fix serialization bug for writing large arrays to npz

[GitBox <gi...@apache.org>]

leezu commented on a change in pull request #19596:
URL: https://github.com/apache/incubator-mxnet/pull/19596#discussion_r532688411



##########
File path: tests/python/unittest/test_numpy_ndarray.py
##########
@@ -999,6 +999,16 @@ def test_setitem_autograd(np_array, index):
     test_getitem_slice_bound()
 
 
+@use_np
+@pytest.mark.parametrize('load_fn', [_np.load, npx.load])
+def test_np_save_load_large_ndarrays(load_fn, tmp_path):
+    weight = mx.np.arange(32768 * 512).reshape((32768, 512))

Review comment:
       The only requirement for triggering the bug is that the total size needs to be greater than the chunk size used by miniz when writing to the file 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org