You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2025/11/23 08:32:29 UTC
(shardingsphere) branch master updated: Refactor string concatenation in statement visitors for improved readability (#37168)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 40ae5985444 Refactor string concatenation in statement visitors for improved readability (#37168)
40ae5985444 is described below
commit 40ae5985444b37937b1a7f8b3fd3d11588e8f301
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Nov 23 16:32:22 2025 +0800
Refactor string concatenation in statement visitors for improved readability (#37168)
---
.../clickhouse/visitor/statement/ClickHouseStatementVisitor.java | 5 ++---
.../parser/engine/hive/visitor/statement/HiveStatementVisitor.java | 5 ++---
.../engine/presto/visitor/statement/PrestoStatementVisitor.java | 5 ++---
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/parser/sql/engine/dialect/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/engine/clickhouse/visitor/statement/ClickHouseStatementVisitor.java b/parser/sql/engine/dialect/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/engine/clickhouse/visitor/statement/ClickHouseStatementVisitor.java
index e0c142600c5..ed76d914fab 100644
--- a/parser/sql/engine/dialect/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/engine/clickhouse/visitor/statement/ClickHouseStatementVisitor.java
+++ b/parser/sql/engine/dialect/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/engine/clickhouse/visitor/statement/ClickHouseStatementVisitor.java
@@ -230,8 +230,7 @@ public abstract class ClickHouseStatementVisitor extends ClickHouseStatementBase
if (null != ctx.IS()) {
String rightText = "";
if (null != ctx.NOT()) {
- rightText = rightText.concat(ctx.start.getInputStream().getText(new Interval(ctx.NOT().getSymbol().getStartIndex(),
- ctx.NOT().getSymbol().getStopIndex()))).concat(" ");
+ rightText = (rightText + ctx.start.getInputStream().getText(new Interval(ctx.NOT().getSymbol().getStartIndex(), ctx.NOT().getSymbol().getStopIndex()))) + " ";
}
Token operatorToken = null;
if (null != ctx.NULL()) {
@@ -244,7 +243,7 @@ public abstract class ClickHouseStatementVisitor extends ClickHouseStatementBase
operatorToken = ctx.FALSE().getSymbol();
}
int startIndex = null == operatorToken ? ctx.IS().getSymbol().getStopIndex() + 2 : operatorToken.getStartIndex();
- rightText = rightText.concat(ctx.start.getInputStream().getText(new Interval(startIndex, ctx.stop.getStopIndex())));
+ rightText = rightText + ctx.start.getInputStream().getText(new Interval(startIndex, ctx.stop.getStopIndex()));
ExpressionSegment right = new LiteralExpressionSegment(ctx.IS().getSymbol().getStopIndex() + 2, ctx.stop.getStopIndex(), rightText);
String text = ctx.start.getInputStream().getText(new Interval(ctx.start.getStartIndex(), ctx.stop.getStopIndex()));
ExpressionSegment left = (ExpressionSegment) visit(ctx.booleanPrimary());
diff --git a/parser/sql/engine/dialect/hive/src/main/java/org/apache/shardingsphere/sql/parser/engine/hive/visitor/statement/HiveStatementVisitor.java b/parser/sql/engine/dialect/hive/src/main/java/org/apache/shardingsphere/sql/parser/engine/hive/visitor/statement/HiveStatementVisitor.java
index fbfb8d57183..59662bb80fe 100644
--- a/parser/sql/engine/dialect/hive/src/main/java/org/apache/shardingsphere/sql/parser/engine/hive/visitor/statement/HiveStatementVisitor.java
+++ b/parser/sql/engine/dialect/hive/src/main/java/org/apache/shardingsphere/sql/parser/engine/hive/visitor/statement/HiveStatementVisitor.java
@@ -291,8 +291,7 @@ public abstract class HiveStatementVisitor extends HiveStatementBaseVisitor<ASTN
// TODO optimize operatorToken
String rightText = "";
if (null != ctx.NOT()) {
- rightText = rightText.concat(ctx.start.getInputStream().getText(new Interval(ctx.NOT().getSymbol().getStartIndex(),
- ctx.NOT().getSymbol().getStopIndex()))).concat(" ");
+ rightText = rightText + ctx.start.getInputStream().getText(new Interval(ctx.NOT().getSymbol().getStartIndex(), ctx.NOT().getSymbol().getStopIndex())) + " ";
}
Token operatorToken = null;
if (null != ctx.NULL()) {
@@ -305,7 +304,7 @@ public abstract class HiveStatementVisitor extends HiveStatementBaseVisitor<ASTN
operatorToken = ctx.FALSE().getSymbol();
}
int startIndex = null == operatorToken ? ctx.IS().getSymbol().getStopIndex() + 2 : operatorToken.getStartIndex();
- rightText = rightText.concat(ctx.start.getInputStream().getText(new Interval(startIndex, ctx.stop.getStopIndex())));
+ rightText = rightText + ctx.start.getInputStream().getText(new Interval(startIndex, ctx.stop.getStopIndex()));
ExpressionSegment right = new LiteralExpressionSegment(ctx.IS().getSymbol().getStopIndex() + 2, ctx.stop.getStopIndex(), rightText);
String text = ctx.start.getInputStream().getText(new Interval(ctx.start.getStartIndex(), ctx.stop.getStopIndex()));
ExpressionSegment left = (ExpressionSegment) visit(ctx.booleanPrimary());
diff --git a/parser/sql/engine/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/engine/presto/visitor/statement/PrestoStatementVisitor.java b/parser/sql/engine/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/engine/presto/visitor/statement/PrestoStatementVisitor.java
index 71f45f9d0e6..520e8b3aa3d 100644
--- a/parser/sql/engine/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/engine/presto/visitor/statement/PrestoStatementVisitor.java
+++ b/parser/sql/engine/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/engine/presto/visitor/statement/PrestoStatementVisitor.java
@@ -307,8 +307,7 @@ public abstract class PrestoStatementVisitor extends PrestoStatementBaseVisitor<
// TODO optimize operatorToken
String rightText = "";
if (null != ctx.NOT()) {
- rightText = rightText.concat(ctx.start.getInputStream().getText(new Interval(ctx.NOT().getSymbol().getStartIndex(),
- ctx.NOT().getSymbol().getStopIndex()))).concat(" ");
+ rightText = rightText + ctx.start.getInputStream().getText(new Interval(ctx.NOT().getSymbol().getStartIndex(), ctx.NOT().getSymbol().getStopIndex())) + " ";
}
Token operatorToken = null;
if (null != ctx.NULL()) {
@@ -321,7 +320,7 @@ public abstract class PrestoStatementVisitor extends PrestoStatementBaseVisitor<
operatorToken = ctx.FALSE().getSymbol();
}
int startIndex = null == operatorToken ? ctx.IS().getSymbol().getStopIndex() + 2 : operatorToken.getStartIndex();
- rightText = rightText.concat(ctx.start.getInputStream().getText(new Interval(startIndex, ctx.stop.getStopIndex())));
+ rightText = rightText + ctx.start.getInputStream().getText(new Interval(startIndex, ctx.stop.getStopIndex()));
ExpressionSegment right = new LiteralExpressionSegment(ctx.IS().getSymbol().getStopIndex() + 2, ctx.stop.getStopIndex(), rightText);
String text = ctx.start.getInputStream().getText(new Interval(ctx.start.getStartIndex(), ctx.stop.getStopIndex()));
ExpressionSegment left = (ExpressionSegment) visit(ctx.booleanPrimary());