[PR] [ISSUE-3856][test] Deepen MybatisPlusAlertStateRepositoryTest with rule deletion and null fired-at ack [rocketmq-dashboard]

["yyqdbngt (via GitHub)" <gi...@apache.org>]

yyqdbngt opened a new pull request, #3856:
URL: https://github.com/apache/rocketmq-dashboard/pull/3856

   ### Motivation
   
   The existing `MybatisPlusAlertStateRepositoryTest` covers revision-guarded saves, conditional acknowledges, and active-state discovery. The `deleteByRuleId` null guard and the null-`firedAt` acknowledge path were untested.
   
   ### Changes
   
   - `deleteByRuleIdShouldDeleteMatchingStatesAndIgnoreNull`: a rule deletion issues one mapper delete while a null rule id is ignored.
   - `acknowledgeWithNullFiredAtIsIgnored`: a missing firing timestamp short-circuits to false without a conditional update.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=MybatisPlusAlertStateRepositoryTest
   [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ISSUE-3856][test] Deepen MybatisPlusAlertStateRepositoryTest with rule deletion and null fired-at ack [rocketmq-dashboard]

["lizhimins (via GitHub)" <gi...@apache.org>]

lizhimins closed pull request #3856: [ISSUE-3856][test] Deepen MybatisPlusAlertStateRepositoryTest with rule deletion and null fired-at ack
URL: https://github.com/apache/rocketmq-dashboard/pull/3856


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org