You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/25 10:43:31 UTC

[GitHub] [camel-k] tadayosi commented on a diff in pull request #3574: fix(e2e): local test when staging

tadayosi commented on code in PR #3574:
URL: https://github.com/apache/camel-k/pull/3574#discussion_r954805611


##########
e2e/local/util.go:
##########
@@ -48,3 +53,10 @@ func StopDockerContainers() {
 		Docker(args...)
 	}
 }
+
+func kamelWithContextAndMaybeStaging(ctx context.Context, args ...string) *cobra.Command {

Review Comment:
   It looks a bit verbose to me. Maybe we can just name it `kamelWithContext` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org