You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by 10110346 <gi...@git.apache.org> on 2017/10/25 06:54:42 UTC

[GitHub] spark pull request #19572: [SPARK-22349]In on-heap mode, when allocating mem...

GitHub user 10110346 opened a pull request:

    https://github.com/apache/spark/pull/19572

    [SPARK-22349]In on-heap mode, when allocating memory from pool,we should fill memory with `MEMORY_DEBUG_FILL_CLEAN_VALUE`

    ## What changes were proposed in this pull request?
    In on-heap mode, when allocating memory from pool,we should fill memory with `MEMORY_DEBUG_FILL_CLEAN_VALUE`
    
    ## How was this patch tested?
    added unit tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/10110346/spark MEMORY_DEBUG

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19572.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19572
    
----
commit 95ae9c3ffd2fb17e6126fce023f7258bdaeb7c0f
Author: liuxian <li...@zte.com.cn>
Date:   2017-10-25T06:30:27Z

    fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83035/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by kiszk <gi...@git.apache.org>.

Github user kiszk commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    LGTM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by 10110346 <gi...@git.apache.org>.

Github user 10110346 commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    cc @sameeragarwal @ericl


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    **[Test build #83035 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83035/testReport)** for PR 19572 at commit [`95ae9c3`](https://github.com/apache/spark/commit/95ae9c3ffd2fb17e6126fce023f7258bdaeb7c0f).
     * This patch **fails due to an unknown error code, -9**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #19572: [SPARK-22349]In on-heap mode, when allocating memory fro...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19572
  
    **[Test build #83036 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83036/testReport)** for PR 19572 at commit [`95ae9c3`](https://github.com/apache/spark/commit/95ae9c3ffd2fb17e6126fce023f7258bdaeb7c0f).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org