[jira] [Comment Edited] (FLINK-31080) Idle slots are not released due to a mismatch in time between DeclarativeSlotPoolService and SlotSharingSlotAllocator

["Samrat Deb (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-31080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17717308#comment-17717308 ] 

Samrat Deb edited comment on FLINK-31080 at 4/27/23 6:33 PM:
-------------------------------------------------------------

[~Weijie Guo] we have worked internally to fix this bug. 
If you are fine , can i share the patch in flink-runtime ? 

cc: [~prabhujoseph] 


was (Author: samrat007):
[~Weijie Guo] we have worked internally to fix this bug. 
If you are fine , can i share the patch to flink ? 

cc: [~prabhujoseph] 

> Idle slots are not released due to a mismatch in time between DeclarativeSlotPoolService and SlotSharingSlotAllocator
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-31080
>                 URL: https://issues.apache.org/jira/browse/FLINK-31080
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.17.0, 1.16.1
>            Reporter: Prabhu Joseph
>            Assignee: Weijie Guo
>            Priority: Major
>              Labels: pull-request-available
>
> Due to a timing mismatch between {{DeclarativeSlotPoolService}} and {{{}SlotSharingSlotAllocator{}}}, idle slots are not released.
> {{DeclarativeSlotPoolService}} uses {{{}SystemClock#relativeTimeMillis{}}}, i.e., {{{}System.nanoTime{}}}() / 1_000_000, while offering a slot, whereas {{SlotSharingSlotAllocator}} uses {{{}System.currentTimeMillis{}}}() while freeing the reserved slot. 
> The idle timeout check fails wrongly as "{{{}System.currentTimeMillis(){}}}" will have a very high value compared to "{{{}SystemClock#relativeTimeMillis{}}}".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)