[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #372: SAMA5 GMAC driver improvements: prevent txtimeout from always firing and fix txbuffer leak during high-volume sends
URL: https://github.com/apache/incubator-nuttx/pull/372#discussion_r383756947
 
 

 ##########
 File path: arch/arm/src/sama5/sam_gmac.c
 ##########
 @@ -1337,8 +1347,9 @@ static void sam_txdone(struct sam_gmac_s *priv)
       up_invalidate_dcache((uintptr_t)txdesc,
                            (uintptr_t)txdesc + sizeof(struct gmac_txdesc_s));
 
-      /* Is this TX descriptor still in use? */
 
+      // Is this TX descriptor done transmitting? (SAMA5D36 datasheet, p. 934)
+      // First TX descriptor in chain GMACTXD_STA_USED = 1
 
 Review comment:
   ```suggestion
         /* First TX descriptor in chain GMACTXD_STA_USED = 1 */
         
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services