You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/02/13 04:05:36 UTC

[GitHub] [flink] bgeng777 opened a new pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

bgeng777 opened a new pull request #18739:
URL: https://github.com/apache/flink/pull/18739


   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   Fix the minor bug when locating `usrlib` with `ClusterEntrypointUtils#tryFindUserLibDirectory` as it will return a wrong usrlib if environment variable `FLINK_LIB_DIR` is pre-configured in the YARN cluster. To get rid of this wrong behavior, this PR sets `FLINK_LIB_DIR` to 'lib' under working dir in YARN containers for JM.
   
   
   ## Brief change log
   
     - Add a ConfigConstant `DEFAULT_FLINK_LIB_DIR`.
     - Set FLINK_LIB_DIR to 'lib' under working dir in JM containers(i.e. YARN's application master container). Note, this PR does not set such env in TM (i.e. YARN's worker containers) as `tryFindUserLibDirectory` will only be used in ClusterEntrypoint in JM containers to generate JobGraph.
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers:  no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 83458365f120c596f8863039e1c91ac56da7562b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052) 
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799",
       "triggerID" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b4ab65d7d448a28cc214e4096bb188593b7da6f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729) 
   * bc616fc3fc62c26ffb971528dc248078ab2dd378 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799",
       "triggerID" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8e0e8e66cbd7a4549e091ae743932d8610dd7b6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f8e0e8e66cbd7a4549e091ae743932d8610dd7b6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b4ab65d7d448a28cc214e4096bb188593b7da6f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729) 
   * bc616fc3fc62c26ffb971528dc248078ab2dd378 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799) 
   * f8e0e8e66cbd7a4549e091ae743932d8610dd7b6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2874986371cbe28aaf3ecb0c541695dc2190c3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326) 
   * a13f47059a7dbb4612bce6812362cc644903b27f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9628d0cc59529303359774663895e783a76a045 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412) 
   * 2b4ab65d7d448a28cc214e4096bb188593b7da6f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   * 89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 83458365f120c596f8863039e1c91ac56da7562b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052) 
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399) 
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   * f9628d0cc59529303359774663895e783a76a045 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a13f47059a7dbb4612bce6812362cc644903b27f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431) 
   * 83458365f120c596f8863039e1c91ac56da7562b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   * 89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399) 
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r816581955



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -830,4 +832,42 @@ private YarnClusterDescriptor createYarnClusterDescriptor(Configuration configur
                 .setYarnClusterInformationRetriever(() -> YARN_MAX_VCORES)
                 .build();
     }
+
+    @Test
+    public void testGenerateApplicationMasterEnv() throws IOException {
+        final Configuration flinkConfig = new Configuration();
+        final File flinkHomeDir = temporaryFolder.newFolder();
+        final String fakeLocalFlinkJar = "./lib/flink_dist.jar";
+        final String fakeClassPath = fakeLocalFlinkJar + ":./usrlib/user.jar";
+        final ApplicationId appId = ApplicationId.newInstance(0, 0);
+        try (final YarnClusterDescriptor yarnClusterDescriptor =
+                createYarnClusterDescriptor(flinkConfig)) {
+            final YarnApplicationFileUploader yarnApplicationFileUploader =
+                    YarnApplicationFileUploader.from(
+                            FileSystem.get(new YarnConfiguration()),
+                            new Path(flinkHomeDir.getPath()),
+                            new ArrayList<>(),
+                            appId,
+                            DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+            final Map<String, String> masterEnv =
+                    yarnClusterDescriptor.generateApplicationMasterEnv(
+                            yarnApplicationFileUploader,
+                            fakeClassPath,
+                            fakeLocalFlinkJar,
+                            appId.toString());
+
+            Assert.assertEquals("./lib", masterEnv.get(ConfigConstants.ENV_FLINK_LIB_DIR));

Review comment:
       Fixed in 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3

##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1829,4 +1809,41 @@ public static void logDetachedClusterInformation(
                 yarnApplicationId,
                 yarnApplicationId);
     }
+
+    @VisibleForTesting
+    Map<String, String> generateApplicationMasterEnv(
+            final YarnApplicationFileUploader fileUploader,
+            final String classPathStr,
+            final String localFlinkJarStr,
+            final String appIdStr)
+            throws IOException {
+        final Map<String, String> env = new HashMap<>();
+        // set YARN classpath
+        env.put(ENV_FLINK_CLASSPATH, classPathStr);
+        Utils.setupYarnClassPath(this.yarnConfiguration, env);
+        // https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnApplicationSecurity.md#identity-on-an-insecure-cluster-hadoop_user_name
+        env.put(
+                YarnConfigKeys.ENV_HADOOP_USER_NAME,
+                UserGroupInformation.getCurrentUser().getUserName());
+        // set user specified app master environment variables
+        env.putAll(
+                ConfigurationUtils.getPrefixedKeyValuePairs(
+                        ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX,
+                        this.flinkConfiguration));
+        // Set FLINK_LIB_DIR to `lib` folder under working dir in container
+        env.put(ENV_FLINK_LIB_DIR, Path.CUR_DIR + "/" + ConfigConstants.DEFAULT_FLINK_LIB_DIR);

Review comment:
       Add in 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b4ab65d7d448a28cc214e4096bb188593b7da6f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729) 
   * bc616fc3fc62c26ffb971528dc248078ab2dd378 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2874986371cbe28aaf3ecb0c541695dc2190c3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2874986371cbe28aaf3ecb0c541695dc2190c3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817405111



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws IOException {
         assertEquals(flinkHomeDir.getPath(), masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
     }
 
+    @Test
+    public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws IOException {

Review comment:
       I checked YARN's relevant codes for [nodemanager](https://github.com/apache/hadoop/blob/91997872155e4b4b99c3dea7baccddbf2af9aa19/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java) and [ApplicationMaster](https://github.com/apache/hadoop/blob/03cfc852791c14fad39db4e5b14104a276c08e59/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java#L199). IIUC,  the system env will be inherited by YARN's containers. So the system env can take effects.
   But I do agree that `CONTAINERIZED_MASTER_ENV_PREFIX` should be tested as well. `ENV_FLINK_LIB_DIR` is an unmodifiable var in our Flink use case when launching containers. 
   I will add the test for `CONTAINERIZED_MASTER_ENV_PREFIX` asap.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1056062747


   @bgeng777 This PR looks good to me. It will be great if you could reorg the commit.
   * [hotfix][yarn] Factor out the generating for application master environments into a separate method
   * [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2874986371cbe28aaf3ecb0c541695dc2190c3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   * f9628d0cc59529303359774663895e783a76a045 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 83458365f120c596f8863039e1c91ac56da7562b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817471176



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws IOException {
         assertEquals(flinkHomeDir.getPath(), masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
     }
 
+    @Test
+    public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws IOException {

Review comment:
       I see your point. I agree current test is useless as it is run in client side. Using `CONTAINERIZED_MASTER_ENV_PREFIX` makes more sense. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817438292



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws IOException {
         assertEquals(flinkHomeDir.getPath(), masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
     }
 
+    @Test
+    public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws IOException {

Review comment:
       `YarnClusterDescriptor` is running on the client side. So I do not think the current test make sense if you really want to test system env on the JM/TM side should not override `ENV_FLINK_LIB_DIR`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r816582211



##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1829,4 +1809,41 @@ public static void logDetachedClusterInformation(
                 yarnApplicationId,
                 yarnApplicationId);
     }
+
+    @VisibleForTesting
+    Map<String, String> generateApplicationMasterEnv(
+            final YarnApplicationFileUploader fileUploader,
+            final String classPathStr,
+            final String localFlinkJarStr,
+            final String appIdStr)
+            throws IOException {
+        final Map<String, String> env = new HashMap<>();
+        // set YARN classpath
+        env.put(ENV_FLINK_CLASSPATH, classPathStr);

Review comment:
       Changed it back.
   At first, I hope to extract some common config setting that will be used both JM and TM container and adjust the order. Later, I find the gain of such refactor is small compared to its risk. When rolling back, the order is not considered(my bad). Though I think the order should be not crucial, I agree the change had better be as small as possible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2b4ab65d7d448a28cc214e4096bb188593b7da6f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 merged pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 merged pull request #18739:
URL: https://github.com/apache/flink/pull/18739


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9628d0cc59529303359774663895e783a76a045 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412) 
   * 2b4ab65d7d448a28cc214e4096bb188593b7da6f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037760090


   This PR has not included new unit/integration tests as I find that this fix relies cluster's environment variable. Will check if we should add a e2e test in next few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1048952832


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   * 89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   * f9628d0cc59529303359774663895e783a76a045 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799",
       "triggerID" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8e0e8e66cbd7a4549e091ae743932d8610dd7b6",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32803",
       "triggerID" : "f8e0e8e66cbd7a4549e091ae743932d8610dd7b6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8e0e8e66cbd7a4549e091ae743932d8610dd7b6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32803) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037748219


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 2c2874986371cbe28aaf3ecb0c541695dc2190c3 (Sun Feb 13 04:10:19 UTC 2022)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 83458365f120c596f8863039e1c91ac56da7562b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1068793090


   Merging this PR now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a13f47059a7dbb4612bce6812362cc644903b27f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a13f47059a7dbb4612bce6812362cc644903b27f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431) 
   * 83458365f120c596f8863039e1c91ac56da7562b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r817387290



##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -854,6 +855,25 @@ public void testGenerateApplicationMasterEnv() throws IOException {
         assertEquals(flinkHomeDir.getPath(), masterEnv.get(YarnConfigKeys.ENV_CLIENT_HOME_DIR));
     }
 
+    @Test
+    public void testEnvFlinkLibDirVarNotOverriddenBySystem() throws IOException {

Review comment:
       I think what we need to test is `ENV_FLINK_LIB_DIR` is not overridden by user specified envs via `CONTAINERIZED_MASTER_ENV_PREFIX`, not overridden by system environment.
   
   ```
   flinkConfig.setString(
                   ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX
                           + ConfigConstants.ENV_FLINK_LIB_DIR,
                   "/path/of/flink-lib");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on a change in pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #18739:
URL: https://github.com/apache/flink/pull/18739#discussion_r814522068



##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1829,4 +1809,41 @@ public static void logDetachedClusterInformation(
                 yarnApplicationId,
                 yarnApplicationId);
     }
+
+    @VisibleForTesting
+    Map<String, String> generateApplicationMasterEnv(
+            final YarnApplicationFileUploader fileUploader,
+            final String classPathStr,
+            final String localFlinkJarStr,
+            final String appIdStr)
+            throws IOException {
+        final Map<String, String> env = new HashMap<>();
+        // set YARN classpath
+        env.put(ENV_FLINK_CLASSPATH, classPathStr);
+        Utils.setupYarnClassPath(this.yarnConfiguration, env);
+        // https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/YarnApplicationSecurity.md#identity-on-an-insecure-cluster-hadoop_user_name
+        env.put(
+                YarnConfigKeys.ENV_HADOOP_USER_NAME,
+                UserGroupInformation.getCurrentUser().getUserName());
+        // set user specified app master environment variables
+        env.putAll(
+                ConfigurationUtils.getPrefixedKeyValuePairs(
+                        ResourceManagerOptions.CONTAINERIZED_MASTER_ENV_PREFIX,
+                        this.flinkConfiguration));
+        // Set FLINK_LIB_DIR to `lib` folder under working dir in container
+        env.put(ENV_FLINK_LIB_DIR, Path.CUR_DIR + "/" + ConfigConstants.DEFAULT_FLINK_LIB_DIR);

Review comment:
       We might need to add a test to guard the `ENV_FLINK_LIB_DIR` will not be overridden by user specified environments.

##########
File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##########
@@ -1829,4 +1809,41 @@ public static void logDetachedClusterInformation(
                 yarnApplicationId,
                 yarnApplicationId);
     }
+
+    @VisibleForTesting
+    Map<String, String> generateApplicationMasterEnv(
+            final YarnApplicationFileUploader fileUploader,
+            final String classPathStr,
+            final String localFlinkJarStr,
+            final String appIdStr)
+            throws IOException {
+        final Map<String, String> env = new HashMap<>();
+        // set YARN classpath
+        env.put(ENV_FLINK_CLASSPATH, classPathStr);

Review comment:
       nit: why do we change the put operation orders as before?

##########
File path: flink-yarn/src/test/java/org/apache/flink/yarn/YarnClusterDescriptorTest.java
##########
@@ -830,4 +832,42 @@ private YarnClusterDescriptor createYarnClusterDescriptor(Configuration configur
                 .setYarnClusterInformationRetriever(() -> YARN_MAX_VCORES)
                 .build();
     }
+
+    @Test
+    public void testGenerateApplicationMasterEnv() throws IOException {
+        final Configuration flinkConfig = new Configuration();
+        final File flinkHomeDir = temporaryFolder.newFolder();
+        final String fakeLocalFlinkJar = "./lib/flink_dist.jar";
+        final String fakeClassPath = fakeLocalFlinkJar + ":./usrlib/user.jar";
+        final ApplicationId appId = ApplicationId.newInstance(0, 0);
+        try (final YarnClusterDescriptor yarnClusterDescriptor =
+                createYarnClusterDescriptor(flinkConfig)) {
+            final YarnApplicationFileUploader yarnApplicationFileUploader =
+                    YarnApplicationFileUploader.from(
+                            FileSystem.get(new YarnConfiguration()),
+                            new Path(flinkHomeDir.getPath()),
+                            new ArrayList<>(),
+                            appId,
+                            DFSConfigKeys.DFS_REPLICATION_DEFAULT);
+            final Map<String, String> masterEnv =
+                    yarnClusterDescriptor.generateApplicationMasterEnv(
+                            yarnApplicationFileUploader,
+                            fakeClassPath,
+                            fakeLocalFlinkJar,
+                            appId.toString());
+
+            Assert.assertEquals("./lib", masterEnv.get(ConfigConstants.ENV_FLINK_LIB_DIR));

Review comment:
       ```suggestion
               assertEquals("./lib", masterEnv.get(ConfigConstants.ENV_FLINK_LIB_DIR));
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     }, {
       "hash" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32729",
       "triggerID" : "2b4ab65d7d448a28cc214e4096bb188593b7da6f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799",
       "triggerID" : "bc616fc3fc62c26ffb971528dc248078ab2dd378",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8e0e8e66cbd7a4549e091ae743932d8610dd7b6",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32803",
       "triggerID" : "f8e0e8e66cbd7a4549e091ae743932d8610dd7b6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * bc616fc3fc62c26ffb971528dc248078ab2dd378 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32799) 
   * f8e0e8e66cbd7a4549e091ae743932d8610dd7b6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32803) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 83458365f120c596f8863039e1c91ac56da7562b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1055565950


   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 0b12e096e97eff0fddc7a2e777f4cd40be5a4df3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   * f9628d0cc59529303359774663895e783a76a045 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9628d0cc59529303359774663895e783a76a045 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32412) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1056081815


   @wangyang0918 No problem. I have updated the commit history. Thank you very much for the guidance!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1049971212


   hi @wangyang0918, refactored the appMasterEnv generation method and added corresponding unit test. Would you mind taking another look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399) 
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   * f9628d0cc59529303359774663895e783a76a045 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1056062747


   @bgeng777 This PR looks already good enough to me. It will be great if you could reorg the commit.
   * [hotfix][yarn] Factor out the generating for application master environments into a separate method
   * [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31431",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "83458365f120c596f8863039e1c91ac56da7562b",
       "triggerType" : "PUSH"
     }, {
       "hash" : "83458365f120c596f8863039e1c91ac56da7562b",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32052",
       "triggerID" : "1048952832",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "0b12e096e97eff0fddc7a2e777f4cd40be5a4df3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32345",
       "triggerID" : "1055565950",
       "triggerType" : "MANUAL"
     }, {
       "hash" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32399",
       "triggerID" : "89b8ca850e24457d3e5c09c4ffa6b6ffd0dff6a3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406",
       "triggerID" : "070f67c5a96eef7252b15f5f8299be16c623ef09",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f9628d0cc59529303359774663895e783a76a045",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9628d0cc59529303359774663895e783a76a045",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 070f67c5a96eef7252b15f5f8299be16c623ef09 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32406) 
   * f9628d0cc59529303359774663895e783a76a045 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037747523


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326",
       "triggerID" : "2c2874986371cbe28aaf3ecb0c541695dc2190c3",
       "triggerType" : "PUSH"
     }, {
       "hash" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a13f47059a7dbb4612bce6812362cc644903b27f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2c2874986371cbe28aaf3ecb0c541695dc2190c3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=31326) 
   * a13f47059a7dbb4612bce6812362cc644903b27f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wangyang0918 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1038901595


   I suggest to factor out the generating application master environments part into a separate method(e.g. `generateApplicationMasterEnvironments()`)  and then add a dedicated test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] bgeng777 commented on pull request #18739: [FLINK-26030][yarn] Set FLINK_LIB_DIR to 'lib' under working dir in YARN containers

Posted by GitBox <gi...@apache.org>.
bgeng777 commented on pull request #18739:
URL: https://github.com/apache/flink/pull/18739#issuecomment-1037760090


   This PR has not included new unit/integration tests as I find that this fix relies cluster's environment variable. Will check if we should add a e2e test in next few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org