You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "vdombrovski (via GitHub)" <gi...@apache.org> on 2024/02/16 09:35:45 UTC
[PR] Add UEFI support [cloudstack-terraform-provider]
vdombrovski opened a new pull request, #83:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/83
This adds a new boolean parameter to the cloudstack_instance resource, called "uefi". When set, the instance will boot in UEFI/Legacy mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
Posted by "vdombrovski (via GitHub)" <gi...@apache.org>.
vdombrovski commented on code in PR #83:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/83#discussion_r1495629658
##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -277,6 +283,11 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta interface{})
p.SetRootdisksize(int64(rootdisksize.(int)))
}
+ if d.Get("uefi").(bool) {
+ p.SetBoottype("UEFI")
+ p.SetBootmode("Legacy")
Review Comment:
I was thinking about adding this as a second step, if the community needs it. Currently I don't have any way to test the UEFI Secure mode (I'm not even sure it works properly in ACS).
For now this is meant to be an easy and naive implementation that covers the most important need, which is to run UEFI cloud images; This is also a pressing issue now that some distros (e.g. Ubuntu) are providing [UEFI only cloud images](https://cloud-images.ubuntu.com/noble/current/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
Posted by "bragonznx (via GitHub)" <gi...@apache.org>.
bragonznx commented on PR #83:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/83#issuecomment-1948077019
@vdombrovski whaouuuuuu : awesome, thanks for this; it's very usefull.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #83:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/83#discussion_r1494973592
##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -277,6 +283,11 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta interface{})
p.SetRootdisksize(int64(rootdisksize.(int)))
}
+ if d.Get("uefi").(bool) {
+ p.SetBoottype("UEFI")
+ p.SetBootmode("Legacy")
Review Comment:
Should the boot mode be configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #83:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add UEFI support [cloudstack-terraform-provider]
Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 commented on code in PR #83:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/83#discussion_r1514083157
##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -277,6 +283,11 @@ func resourceCloudStackInstanceCreate(d *schema.ResourceData, meta interface{})
p.SetRootdisksize(int64(rootdisksize.(int)))
}
+ if d.Get("uefi").(bool) {
+ p.SetBoottype("UEFI")
+ p.SetBootmode("Legacy")
Review Comment:
@rohityadavcloud Is this fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org