You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/01/17 06:50:26 UTC
[10/27] james-project git commit: JAMES-2641
DefaultImapProcessorFactory have many unused fields/methods
JAMES-2641 DefaultImapProcessorFactory have many unused fields/methods
Only 2 static methods are used
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/9e34f173
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/9e34f173
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/9e34f173
Branch: refs/heads/master
Commit: 9e34f173c6aca3f03c1e9e8aaa2fd46fb884c1e7
Parents: d35e8a6
Author: Benoit Tellier <bt...@linagora.com>
Authored: Thu Jan 10 15:27:40 2019 +0700
Committer: Benoit Tellier <bt...@linagora.com>
Committed: Thu Jan 17 10:23:41 2019 +0700
----------------------------------------------------------------------
.../main/DefaultImapProcessorFactory.java | 69 ++------------------
1 file changed, 4 insertions(+), 65 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/james-project/blob/9e34f173/protocols/imap/src/main/java/org/apache/james/imap/processor/main/DefaultImapProcessorFactory.java
----------------------------------------------------------------------
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/main/DefaultImapProcessorFactory.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/main/DefaultImapProcessorFactory.java
index 3af2b8e..ff6d78f 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/main/DefaultImapProcessorFactory.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/main/DefaultImapProcessorFactory.java
@@ -32,9 +32,6 @@ import org.apache.james.mailbox.quota.QuotaManager;
import org.apache.james.mailbox.quota.QuotaRootResolver;
import org.apache.james.metrics.api.MetricFactory;
-/**
- *
- */
public class DefaultImapProcessorFactory {
public static ImapProcessor createDefaultProcessor(MailboxManager mailboxManager, SubscriptionManager subscriptionManager, QuotaManager quotaManager, QuotaRootResolver quotaRootResolver,
@@ -44,72 +41,14 @@ public class DefaultImapProcessorFactory {
public static ImapProcessor createXListSupportingProcessor(MailboxManager mailboxManager, SubscriptionManager subscriptionManager,
MailboxTyper mailboxTyper, QuotaManager quotaManager, QuotaRootResolver quotaRootResolver, MetricFactory metricFactory) {
+
final StatusResponseFactory statusResponseFactory = new UnpooledStatusResponseFactory();
final UnknownRequestProcessor unknownRequestImapProcessor = new UnknownRequestProcessor(statusResponseFactory);
- final ImapProcessor imap4rev1Chain = DefaultProcessorChain.createDefaultChain(unknownRequestImapProcessor, mailboxManager, subscriptionManager, statusResponseFactory, mailboxTyper, quotaManager, quotaRootResolver, metricFactory);
- return new ImapResponseMessageProcessor(imap4rev1Chain);
- }
-
- private MailboxManager mailboxManager;
- private SubscriptionManager subscriptionManager;
- private MailboxTyper mailboxTyper;
- private QuotaManager quotaManager;
- private QuotaRootResolver quotaRootResolver;
- private MetricFactory metricFactory;
-
- public final void setMailboxManager(MailboxManager mailboxManager) {
- this.mailboxManager = mailboxManager;
- }
-
- public final void setSubscriptionManager(SubscriptionManager subscriptionManager) {
- this.subscriptionManager = subscriptionManager;
- }
-
- public void setMailboxTyper(MailboxTyper mailboxTyper) {
- this.mailboxTyper = mailboxTyper;
- }
-
- public void setQuotaManager(QuotaManager quotaManager) {
- this.quotaManager = quotaManager;
- }
-
- public void setQuotaRootResolver(QuotaRootResolver quotaRootResolver) {
- this.quotaRootResolver = quotaRootResolver;
- }
- public final MailboxManager getMailboxManager() {
- return mailboxManager;
- }
-
- public final SubscriptionManager getSubscriptionManager() {
- return subscriptionManager;
- }
-
- public MailboxTyper getMailboxTyper() {
- return mailboxTyper;
- }
-
- public QuotaManager getQuotaManager() {
- return quotaManager;
- }
+ final ImapProcessor imap4rev1Chain = DefaultProcessorChain.createDefaultChain(unknownRequestImapProcessor,
+ mailboxManager, subscriptionManager, statusResponseFactory, mailboxTyper, quotaManager, quotaRootResolver, metricFactory);
- public QuotaRootResolver getQuotaRootResolver() {
- return quotaRootResolver;
- }
-
- public MetricFactory getMetricFactory() {
- return metricFactory;
- }
-
- public void setMetricFactory(MetricFactory metricFactory) {
- this.metricFactory = metricFactory;
- }
-
- /**
- * Create the {@link ImapProcessor}
- */
- public ImapProcessor buildImapProcessor() {
- return createDefaultProcessor(mailboxManager, subscriptionManager, quotaManager, quotaRootResolver, metricFactory);
+ return new ImapResponseMessageProcessor(imap4rev1Chain);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org