You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/06 13:28:22 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #11172: feat: possible to turn off SQL templating
dpgaspar opened a new pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172
### SUMMARY
Use a new feature flag to make it possible to disable SQL templating
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#discussion_r500431858
##########
File path: UPDATING.md
##########
@@ -23,6 +23,8 @@ assists people when migrating to a new version.
## Next
+* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default, to turn it by setting `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
Review comment:
Nit:
```suggestion
* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> Merging [#11172](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 61.49% -4.09%
==========================================
Files 828 828
Lines 39162 39164 +2
Branches 3694 3589 -105
==========================================
- Hits 25681 24084 -1597
- Misses 13371 14900 +1529
- Partials 110 180 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `61.01% <100.00%> (+0.07%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [2a447ff...2005044](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
=========================================
Coverage ? 60.58%
=========================================
Files ? 391
Lines ? 24478
Branches ? 0
=========================================
Hits ? 14829
Misses ? 9649
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.58% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [3d7b805...0178361](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
=========================================
Coverage ? 61.12%
=========================================
Files ? 391
Lines ? 24489
Branches ? 0
=========================================
Hits ? 14968
Misses ? 9521
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `61.12% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [3d7b805...0178361](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> Merging [#11172](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 61.38% -4.19%
==========================================
Files 828 828
Lines 39162 39164 +2
Branches 3694 3589 -105
==========================================
- Hits 25681 24042 -1639
- Misses 13371 14942 +1571
- Partials 110 180 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.84% <100.00%> (-0.10%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [2a447ff...2005044](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
=========================================
Coverage ? 60.56%
=========================================
Files ? 391
Lines ? 24489
Branches ? 0
=========================================
Hits ? 14832
Misses ? 9657
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.56% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [3d7b805...0178361](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> Merging [#11172](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `4.49%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 61.07% -4.50%
==========================================
Files 828 828
Lines 39162 39164 +2
Branches 3694 3589 -105
==========================================
- Hits 25681 23920 -1761
- Misses 13371 15064 +1693
- Partials 110 180 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `62.30% <ø> (ø)` | |
| #python | `60.34% <100.00%> (-0.60%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
| [...ator-superset/superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tor-superset/superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL0FwcC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...r-superset/superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZXhwbG9yZS9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...superset/superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL2luZGV4LmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...uperset/superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBDb2xvcnMuanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvY2hhcnQvQ2hhcnRDb250YWluZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...set/superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvc2V0dXAvc2V0dXBGb3JtYXR0ZXJzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [2a447ff...2005044](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
=========================================
Coverage ? 59.07%
=========================================
Files ? 794
Lines ? 37851
Branches ? 3429
=========================================
Hits ? 22361
Misses ? 15298
Partials ? 192
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.32% <ø> (?)` | |
| #python | `61.12% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [3d7b805...0178361](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> Merging [#11172](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.60%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 59.96% -5.61%
==========================================
Files 828 392 -436
Lines 39162 24563 -14599
Branches 3694 0 -3694
==========================================
- Hits 25681 14730 -10951
+ Misses 13371 9833 -3538
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `59.96% <100.00%> (-0.98%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.90% <100.00%> (-0.05%)` | :arrow_down: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| ... and [456 more](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [2a447ff...2005044](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#discussion_r500674569
##########
File path: UPDATING.md
##########
@@ -23,6 +23,8 @@ assists people when migrating to a new version.
## Next
+* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
Review comment:
while you're in here, could you move the existing `Next` stuff to `0.37.2`? Looks like that wasn't done yet.
Also, make sure you update the PR number
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#discussion_r501260802
##########
File path: UPDATING.md
##########
@@ -23,6 +23,8 @@ assists people when migrating to a new version.
## Next
+* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
Review comment:
ah, gotcha. i forgot that 0.37.2 was only cherrypicked PRs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#discussion_r500434274
##########
File path: UPDATING.md
##########
@@ -23,6 +23,8 @@ assists people when migrating to a new version.
## Next
+* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default, to turn it by setting `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
Review comment:
Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> Merging [#11172](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2a447ff46619d5193cde6f1eb1acc6781dcee056?el=desc) will **decrease** coverage by `5.28%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
==========================================
- Coverage 65.57% 60.29% -5.29%
==========================================
Files 828 392 -436
Lines 39162 24574 -14588
Branches 3694 0 -3694
==========================================
- Hits 25681 14817 -10864
+ Misses 13371 9757 -3614
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.29% <100.00%> (-0.65%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (+0.86%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `86.74% <0.00%> (-0.83%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.56% <0.00%> (-0.28%)` | :arrow_down: |
| ... and [440 more](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [2a447ff...2005044](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-705177515
@dpgaspar I think it's OK to merge this once conflicts are resolved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#discussion_r500832837
##########
File path: UPDATING.md
##########
@@ -23,6 +23,8 @@ assists people when migrating to a new version.
## Next
+* [10887](https://github.com/apache/incubator-superset/pull/11172): Breaking change: SQL templating is turned off be default. To turn it on set `ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
Review comment:
Just checked, and the UPDATING is absolutely correct, there are no warning or breaking changes on 0.37.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
=========================================
Coverage ? 59.30%
=========================================
Files ? 794
Lines ? 37851
Branches ? 3429
=========================================
Hits ? 22449
Misses ? 15218
Partials ? 184
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.98% <ø> (?)` | |
| #python | `61.12% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [3d7b805...0178361](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11172: chore: turn SQL templating off by default
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11172:
URL: https://github.com/apache/incubator-superset/pull/11172#issuecomment-704787129
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@3d7b805`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11172 +/- ##
=========================================
Coverage ? 61.07%
=========================================
Files ? 391
Lines ? 24489
Branches ? 0
=========================================
Hits ? 14957
Misses ? 9532
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `61.07% <100.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <ø> (ø)` | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11172/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.81% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=footer). Last update [3d7b805...0178361](https://codecov.io/gh/apache/incubator-superset/pull/11172?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org