You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 09:04:54 UTC
[GitHub] [spark] beliefer opened a new pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
beliefer opened a new pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018
### What changes were proposed in this pull request?
This PR follows https://github.com/apache/spark/pull/27481.
If test case A uses `--IMPORT` to import test case B and test case B contains bracketed comments, we need to support it too.
### Why are the changes needed?
Golden files can't display well.
### Does this PR introduce any user-facing change?
'No'.
### How was this patch tested?
New UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603726653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25041/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604392666
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25127/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #28018:
[SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604207020
> I think this issue is worth filing a new jira.
OK. I created a new JIRA and update the title of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604392658
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398218911
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -1,12 +1,5 @@
-- Test comments.
-
--- the first case of bracketed comment
---QUERY-DELIMITER-START
-/* This is the first example of bracketed comment.
-SELECT 'ommented out content' AS first;
-*/
-SELECT 'selected content' AS first;
---QUERY-DELIMITER-END
+--IMPORT nested-comments.sql
Review comment:
What did this means?
```
Golden files can't display well.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603726062
**[Test build #120329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120329/testReport)** for PR 28018 at commit [`bbb9a6a`](https://github.com/apache/spark/commit/bbb9a6ae71ffaf0e45557c186c257f8f6c9afafe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398363370
##########
File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql
##########
@@ -0,0 +1,9 @@
+-- This test case just used to test imported bracketed comments.
+
+-- the first case of bracketed comment
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
Review comment:
This is not a nested comment, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398261515
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -256,20 +256,23 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
def splitWithSemicolon(seq: Seq[String]) = {
seq.mkString("\n").split("(?<=[^\\\\]);")
}
- val input = fileToString(new File(testCase.inputFile))
- val (comments, code) = input.split("\n").partition { line =>
+ def splitCommentsAndCodes(input: String) = input.split("\n").partition { line =>
Review comment:
Of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604392658
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604398826
**[Test build #120420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120420/testReport)** for PR 28018 at commit [`1e60d83`](https://github.com/apache/spark/commit/1e60d836b5e5f0cef7eeecf6683bf7857426031c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398485736
##########
File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql
##########
@@ -0,0 +1,9 @@
+-- This test case just used to test imported bracketed comments.
+
+-- the first case of bracketed comment
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
Review comment:
yea, it's not necessary to separate this test file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604392666
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25127/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603895607
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120329/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604538268
**[Test build #120419 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120419/testReport)** for PR 28018 at commit [`fddcbe0`](https://github.com/apache/spark/commit/fddcbe0903a72fff0b4656790d73e2eb5969af4e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398261109
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -1,12 +1,5 @@
-- Test comments.
-
--- the first case of bracketed comment
---QUERY-DELIMITER-START
-/* This is the first example of bracketed comment.
-SELECT 'ommented out content' AS first;
-*/
-SELECT 'selected content' AS first;
---QUERY-DELIMITER-END
+--IMPORT nested-comments.sql
Review comment:
I updated the description to `Golden files can't display the bracketed comments in imported test cases`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603895607
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120329/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603979738
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398507846
##########
File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql
##########
@@ -0,0 +1,9 @@
+-- This test case just used to test imported bracketed comments.
+
+-- the first case of bracketed comment
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
Review comment:
OK. I will revert it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604539573
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603979746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120341/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398404075
##########
File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql
##########
@@ -0,0 +1,9 @@
+-- This test case just used to test imported bracketed comments.
+
+-- the first case of bracketed comment
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
Review comment:
This is a bracketed comments.
Maybe I need change `nested-comments.sql` to `imported-comments.sql`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604392066
**[Test build #120419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120419/testReport)** for PR 28018 at commit [`fddcbe0`](https://github.com/apache/spark/commit/fddcbe0903a72fff0b4656790d73e2eb5969af4e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603779774
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604565823
**[Test build #120420 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120420/testReport)** for PR 28018 at commit [`1e60d83`](https://github.com/apache/spark/commit/1e60d836b5e5f0cef7eeecf6683bf7857426031c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604399392
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603779199
**[Test build #120341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120341/testReport)** for PR 28018 at commit [`cec4670`](https://github.com/apache/spark/commit/cec4670d5f6c8c3fe1c06d71b6545d4729daea7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603726653
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25041/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603779782
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25052/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603979738
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398435094
##########
File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql
##########
@@ -0,0 +1,9 @@
+-- This test case just used to test imported bracketed comments.
+
+-- the first case of bracketed comment
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
Review comment:
maybe updating `SQLQueryTestSuite` only is good enough. It's an obvious bug that we forget to handle `QUERY-DELIMITER` in imported code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603893810
**[Test build #120329 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120329/testReport)** for PR 28018 at commit [`bbb9a6a`](https://github.com/apache/spark/commit/bbb9a6ae71ffaf0e45557c186c257f8f6c9afafe).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603972438
**[Test build #120341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120341/testReport)** for PR 28018 at commit [`cec4670`](https://github.com/apache/spark/commit/cec4670d5f6c8c3fe1c06d71b6545d4729daea7d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28018: [SPARK-31262][SQL][TESTS]
Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604732833
Thanks! Merged to master/3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604392066
**[Test build #120419 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120419/testReport)** for PR 28018 at commit [`fddcbe0`](https://github.com/apache/spark/commit/fddcbe0903a72fff0b4656790d73e2eb5969af4e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604539580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120419/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604567575
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120420/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398296786
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -1,12 +1,5 @@
-- Test comments.
-
--- the first case of bracketed comment
---QUERY-DELIMITER-START
-/* This is the first example of bracketed comment.
-SELECT 'ommented out content' AS first;
-*/
-SELECT 'selected content' AS first;
---QUERY-DELIMITER-END
+--IMPORT nested-comments.sql
Review comment:
OK. I have put the output example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603779782
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25052/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604175237
I think this issue is worth filing a new jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603779774
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604567560
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604539573
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604399392
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603852860
cc @cloud-fan @maropu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603895593
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603979746
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120341/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604398826
**[Test build #120420 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120420/testReport)** for PR 28018 at commit [`1e60d83`](https://github.com/apache/spark/commit/1e60d836b5e5f0cef7eeecf6683bf7857426031c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603895593
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604749877
@maropu @cloud-fan @dongjoon-hyun Thanks for all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604399406
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25128/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604539580
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120419/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #28018:
[SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398444573
##########
File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql
##########
@@ -0,0 +1,9 @@
+-- This test case just used to test imported bracketed comments.
+
+-- the first case of bracketed comment
+--QUERY-DELIMITER-START
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
Review comment:
You means I shouldn't change `comments.sql` and add `nested-comments.sql` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603726650
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603726650
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398219344
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -256,20 +256,23 @@ class SQLQueryTestSuite extends QueryTest with SharedSparkSession {
def splitWithSemicolon(seq: Seq[String]) = {
seq.mkString("\n").split("(?<=[^\\\\]);")
}
- val input = fileToString(new File(testCase.inputFile))
- val (comments, code) = input.split("\n").partition { line =>
+ def splitCommentsAndCodes(input: String) = input.split("\n").partition { line =>
Review comment:
Is this fix related to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604567575
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120420/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604567560
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603779199
**[Test build #120341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120341/testReport)** for PR 28018 at commit [`cec4670`](https://github.com/apache/spark/commit/cec4670d5f6c8c3fe1c06d71b6545d4729daea7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28018:
[SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28018: [SPARK-31262][SQL][TESTS] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-604399406
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25128/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#discussion_r398264464
##########
File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
##########
@@ -1,12 +1,5 @@
-- Test comments.
-
--- the first case of bracketed comment
---QUERY-DELIMITER-START
-/* This is the first example of bracketed comment.
-SELECT 'ommented out content' AS first;
-*/
-SELECT 'selected content' AS first;
---QUERY-DELIMITER-END
+--IMPORT nested-comments.sql
Review comment:
Also, could you put an output example before/after this PR in the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28018:
[SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28018: [SPARK-30758][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments
URL: https://github.com/apache/spark/pull/28018#issuecomment-603726062
**[Test build #120329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120329/testReport)** for PR 28018 at commit [`bbb9a6a`](https://github.com/apache/spark/commit/bbb9a6ae71ffaf0e45557c186c257f8f6c9afafe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org