You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/15 05:44:05 UTC

[GitHub] [skywalking] hanahmily edited a comment on issue #4514: Add selector property in application.yml

hanahmily edited a comment on issue #4514: Add selector property in application.yml
URL: https://github.com/apache/skywalking/pull/4514#issuecomment-599170923
 
 
   @kezhenxu94 Good job! Except for some nits.
   
   I prefer to remove unnecessary environment variable converting in entrypoint script, so let's just delete them. But to keep `so11y` related segments is a good idea because of the link between receiver and telemetry. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services