You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/09 08:09:35 UTC

[GitHub] [incubator-nuttx-apps] Gary-Hobson opened a new pull request, #1314: quickjs: add qjs tool configuration item

Gary-Hobson opened a new pull request, #1314:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1314

   ## Summary
   Do not compile and generate the qjs tool by default
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1314: quickjs: add qjs tool configuration item

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1314:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1314: quickjs: add qjs tool configuration item

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1314:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1314#discussion_r966831162


##########
interpreters/quickjs/Makefile:
##########
@@ -59,10 +52,12 @@ endif
 
 VPATH += $(QUICKJS_UNPACK)
 
+ifeq ($(CONFIG_INTERPRETERS_QUICKJS_NONE),)

Review Comment:
   ```suggestion
   ifneq ($(CONFIG_INTERPRETERS_QUICKJS_NONE),y)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org