You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 22:26:13 UTC

[GitHub] [airflow] dstandish commented on pull request #13152: Convert columns in get_pandas_df to lowercase SnowflakeHook

dstandish commented on pull request #13152:
URL: https://github.com/apache/airflow/pull/13152#issuecomment-748349379


   it's not true that everything in snowflake is uppercase.  snowflake renders unquoted identifiers as uppercase. but quoted identifiers it leaves as is.
   
   you can do `create table "MyCrazyTable" ...` and then when you do `select * from mycrazytable` it will fail.
   
   so this would be no problem if you are never quoting identifiers in your code.  however, if that's not true it could cause problems.
   
   perhaps a better example is this:
   ```create temp table _my_table ( "col1" int, col1 int);```
   
   with your change you might run into trouble
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org