[GitHub] mdindoffer commented on a change in pull request #322: Migrate to Files.new* creation of I/O streams during IDE boot

[GitBox <gi...@apache.org>]

mdindoffer commented on a change in pull request #322: Migrate to Files.new* creation of I/O streams during IDE boot
URL: https://github.com/apache/incubator-netbeans/pull/322#discussion_r159829850
 
 

 ##########
 File path: openide.filesystems/src/org/openide/filesystems/JarFileSystem.java
 ##########
 @@ -503,24 +503,16 @@ private InputStream getTemporaryInputStream(JarFile jf, JarEntry je, boolean for
         if (createContent || forceRecreate) {
             // JDK 1.3 contains bug #4336753
             //is = j.getInputStream (je);
 
 Review comment:
   Are you sure?
   I left it there, because the code underneath still calls the 'getInputStream4336753()'.
   I think this is really obsolete and the entire method can be deleted, but I wanted to make this PR focused on one thing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists