You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ju...@apache.org on 2010/01/20 10:44:39 UTC

svn commit: r901115 - /pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType0Font.java

Author: jukka
Date: Wed Jan 20 09:43:55 2010
New Revision: 901115

URL: http://svn.apache.org/viewvc?rev=901115&view=rev
Log:
PDFBOX-605: Better support for Type0 fonts

Replace a frequent log message with a reference to the issue tracker.

Modified:
    pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType0Font.java

Modified: pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType0Font.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType0Font.java?rev=901115&r1=901114&r2=901115&view=diff
==============================================================================
--- pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType0Font.java (original)
+++ pdfbox/trunk/src/main/java/org/apache/pdfbox/pdmodel/font/PDType0Font.java Wed Jan 20 09:43:55 2010
@@ -18,18 +18,19 @@
 
 import java.awt.Graphics;
 import java.awt.geom.AffineTransform;
+import java.io.IOException;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
 import org.apache.pdfbox.cos.COSArray;
 import org.apache.pdfbox.cos.COSDictionary;
 import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.pdmodel.common.PDRectangle;
 
-import java.io.IOException;
-
 /**
- * This is implementation of the Type0 Font.
+ * This is implementation of the Type0 Font. Note that currently
+ * this class simply falls back to the Type1 font implementation
+ * when drawing text.
+ * See <a href="https://issues.apache.org/jira/browse/PDFBOX-605">PDFBOX-605</a>
+ * for the related improvement issue.
  *
  * @author <a href="mailto:ben@benlitchfield.com">Ben Litchfield</a>
  * @version $Revision: 1.9 $
@@ -37,11 +38,6 @@
 public class PDType0Font extends /*PDFont following is a hack ...*/ PDType1Font
 {
 
-    /**
-     * Log instance.
-     */
-    private static final Log log = LogFactory.getLog(PDType0Font.class);
-
     private PDFont descendentFont;
     /**
      * Constructor.
@@ -68,9 +64,8 @@
     public void drawString( String string, Graphics g, float fontSize, AffineTransform at, float x, float y ) 
         throws IOException
     {
-        //throw new RuntimeException( "Not yet implemented" );
+        // TODO: PDFBOX-605: Better support for Type0 fonts 
         super.drawString(string, g, fontSize, at, x, y);
-        log.info("Called Type1Font.drawString since Type0 is not yet implemented");
     }
 
     /**