[GitHub] [incubator-pegasus] hycdong commented on a change in pull request #862: feat(online_migration): part3 - support ingestion_behind for pegasus

[GitBox <gi...@apache.org>]

hycdong commented on a change in pull request #862:
URL: https://github.com/apache/incubator-pegasus/pull/862#discussion_r778724426



##########
File path: src/server/pegasus_server_impl.cpp
##########
@@ -2695,6 +2699,22 @@ void pegasus_server_impl::update_user_specified_compaction(
     }
 }
 
+void pegasus_server_impl::update_allow_ingest_behind(const std::map<std::string, std::string> &envs,
+                                                     bool default_value)
+{
+    const auto &iter = envs.find(ROCKSDB_ALLOW_INGEST_BEHIND);
+    if (iter == envs.end()) {
+        _allow_ingest_behind = false;

Review comment:
       If `ROCKSDB_ALLOW_INGEST_BEHIND` can't be found in app_envs, it should be set as false.
   `default_value` only be used when app ROCKSDB_ALLOW_INGEST_BEHIND is invalid bool, we set it as default_value. 
   If the db exists before, default_value is the lastest option value, if not, default_value is false. I will update this function comment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org