You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/10 08:22:44 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix python lint
zhengruifeng opened a new pull request, #38597:
URL: https://github.com/apache/spark/pull/38597
### What changes were proposed in this pull request?
Fix python lint
### Why are the changes needed?
https://github.com/apache/spark/pull/38541 breaks the linter
```
starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/sql/connect/plan.py:683: error: Argument 1 to "plan" of "LogicalPlan" has incompatible type "Optional[RemoteSparkSession]"; expected "RemoteSparkSession" [arg-type]
python/pyspark/sql/connect/plan.py:815: error: Argument 1 to "plan" of "LogicalPlan" has incompatible type "Optional[RemoteSparkSession]"; expected "RemoteSparkSession" [arg-type]
Found 2 errors in 1 file (checked 369 source files)
1
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
local test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1309999519
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
URL: https://github.com/apache/spark/pull/38597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1309997726
@grundprinzip I dont know, the package versions do not change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1311135819
@amaliujia +1, hard to figure out what happened
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1309998801
python linter in this PR has passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1309974634
@zhengruifeng How did this escape the linter check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix python lint
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1309931150
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38597: [SPARK-41034][CONNECT][PYTHON][FOLLOW-UP] Fix mypy annotations test
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38597:
URL: https://github.com/apache/spark/pull/38597#issuecomment-1310712847
I have seen mysterious mypy inconsistency things... this is another example...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org