[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #199: Remove code corresponding to Maven 2.x and JDK 7

[GitBox <gi...@apache.org>]

slawekjaranowski commented on code in PR #199:
URL: https://github.com/apache/maven-integration-testing/pull/199#discussion_r971327783


##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0294MergeGlobalAndUserSettingsTest.java:
##########
@@ -53,16 +53,9 @@ public void testitMNG294()
         verifier.deleteDirectory( "target" );
         verifier.addCliOption( "--settings" );
         verifier.addCliOption( "user-settings.xml" );
-        if ( matchesVersionRange( "[2.1.0-M2,)" ) )
-        {
-            // dedicated CLI option only available since MNG-3914
-            verifier.addCliOption( "--global-settings" );
-            verifier.addCliOption( "global-settings.xml" );
-        }
-        else
-        {
-            verifier.setSystemProperty( "org.apache.maven.global-settings", "global-settings.xml" );
-        }
+        verifier.addCliOption( "--global-settings" );
+        verifier.addCliOption( "global-settings.xml" );
+
         if ( matchesVersionRange( "(3.2.5,)" ) )
         {
             verifier.getSystemProperties().put( "maven.multiModuleProjectDirectory", testDir.getAbsolutePath() );

Review Comment:
   Even more `multiModuleProjectDirectory` is set by Verifier 1.8.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org