You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2012/04/27 15:29:48 UTC

[jira] [Created] (HDFS-3334) ByteRangeInputStream leaks streams

Daryn Sharp created HDFS-3334:
---------------------------------

             Summary: ByteRangeInputStream leaks streams
                 Key: HDFS-3334
                 URL: https://issues.apache.org/jira/browse/HDFS-3334
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: hdfs client
    Affects Versions: 0.24.0, 0.23.3, 2.0.0
            Reporter: Daryn Sharp
            Assignee: Daryn Sharp


{{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HDFS-3334:
------------------------------

    Status: Patch Available  (was: Open)
    
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263876#comment-13263876 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3334:
----------------------------------------------

{code}
      case SEEK:
        if (in != null) {
          in.close();
        }
        in = openInputStream();
        status = StreamStatus.NORMAL;
        break;
{code}
I think the SEEK case can be simplified as above.  Otherwise, the are unnecessary status transitions: SEEK -> CLOSE -> SEEK -> NORMAL.
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264331#comment-13264331 ] 

Hudson commented on HDFS-3334:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1063 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1063/])
    HDFS-3334. Fix ByteRangeInputStream stream leakage.  Contributed by Daryn Sharp (Revision 1331570)

     Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331570
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java

                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy closed HDFS-3334.
-------------------------------

    
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3, 2.0.2-alpha
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264313#comment-13264313 ] 

Hudson commented on HDFS-3334:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1028 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1028/])
    HDFS-3334. Fix ByteRangeInputStream stream leakage.  Contributed by Daryn Sharp (Revision 1331570)

     Result = FAILURE
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331570
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java

                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263933#comment-13263933 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-3334:
----------------------------------------------

+1 patch looks good.  Since the change is minor, I will run some test and then commit the patch without waiting for Jerkins again.
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264308#comment-13264308 ] 

Hudson commented on HDFS-3334:
------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #241 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/241/])
    svn merge -c 1331570 from trunk for HDFS-3334. Fix ByteRangeInputStream stream leakage. (Revision 1331573)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331573
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java

                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263943#comment-13263943 ] 

Hudson commented on HDFS-3334:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2146 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2146/])
    HDFS-3334. Fix ByteRangeInputStream stream leakage.  Contributed by Daryn Sharp (Revision 1331570)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331570
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java

                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HDFS-3334:
------------------------------

    Attachment: HDFS-3334.patch

Implement {{close}} and add a {{CLOSED}} state for the stream.  {{getInputStream}} was broken into two methods to facilitate mockable testing.  The resulting reduction in indentation makes the patch look much bigger than it really is.
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263941#comment-13263941 ] 

Hudson commented on HDFS-3334:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2220 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2220/])
    HDFS-3334. Fix ByteRangeInputStream stream leakage.  Contributed by Daryn Sharp (Revision 1331570)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331570
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java

                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263709#comment-13263709 ] 

Hadoop QA commented on HDFS-3334:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12524856/HDFS-3334.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2342//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2342//console

This message is automatically generated.
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263962#comment-13263962 ] 

Hudson commented on HDFS-3334:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2163 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2163/])
    HDFS-3334. Fix ByteRangeInputStream stream leakage.  Contributed by Daryn Sharp (Revision 1331570)

     Result = ABORTED
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1331570
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/ByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestByteRangeInputStream.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHftpFileSystem.java

                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tsz Wo (Nicholas), SZE updated HDFS-3334:
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.3
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

I have committed this.  Thanks, Daryn!
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263967#comment-13263967 ] 

Hadoop QA commented on HDFS-3334:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12524909/HDFS-3334-1.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified test files.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2345//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2345//console

This message is automatically generated.
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>             Fix For: 0.23.3
>
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HDFS-3334) ByteRangeInputStream leaks streams

Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daryn Sharp updated HDFS-3334:
------------------------------

    Attachment: HDFS-3334-1.patch

Sure, I simplified it.  I had originally done it that way, but thought it would be better to not directly manipulate the underlying stream outside of the method intended to do the delegation.
                
> ByteRangeInputStream leaks streams
> ----------------------------------
>
>                 Key: HDFS-3334
>                 URL: https://issues.apache.org/jira/browse/HDFS-3334
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.24.0, 0.23.3, 2.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>         Attachments: HDFS-3334-1.patch, HDFS-3334.patch
>
>
> {{HftpFileSystem.ByteRangeInputStream}} does not implement {{close}} so it leaks the underlying stream(s).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira