You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "kingsword09 (via GitHub)" <gi...@apache.org> on 2025/09/22 07:24:17 UTC
[PR] ci: switches memcached image to bitnamisecure image [opendal]
kingsword09 opened a new pull request, #6583:
URL: https://github.com/apache/opendal/pull/6583
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Related #6435.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: switches memcached image to bitnamisecure image [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #6583:
URL: https://github.com/apache/opendal/pull/6583#discussion_r2367190093
##########
.github/services/memcached/memcached_with_auth/action.yml:
##########
@@ -25,12 +25,25 @@ runs:
shell: bash
working-directory: fixtures/memcached
run: docker compose -f docker-compose-memcached-with-auth.yml up -d --wait
+
+ - name: Print memcached logs on failure
+ if: failure()
+ shell: bash
+ working-directory: fixtures/memcached
+ run: |
+ echo "==== docker ps -a ===="
+ docker ps -a
+ echo "==== docker logs memcached-memcached-1 ===="
+ docker logs memcached-memcached-1 || true
+ echo "==== docker compose logs ===="
+ docker compose -f docker-compose-memcached-with-auth.yml logs || true
+
Review Comment:
Do we need to to remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ci: switches memcached image to bitnamisecure image [opendal]
Posted by "kingsword09 (via GitHub)" <gi...@apache.org>.
kingsword09 commented on code in PR #6583:
URL: https://github.com/apache/opendal/pull/6583#discussion_r2367201161
##########
.github/services/memcached/memcached_with_auth/action.yml:
##########
@@ -25,12 +25,25 @@ runs:
shell: bash
working-directory: fixtures/memcached
run: docker compose -f docker-compose-memcached-with-auth.yml up -d --wait
+
+ - name: Print memcached logs on failure
+ if: failure()
+ shell: bash
+ working-directory: fixtures/memcached
+ run: |
+ echo "==== docker ps -a ===="
+ docker ps -a
+ echo "==== docker logs memcached-memcached-1 ===="
+ docker logs memcached-memcached-1 || true
+ echo "==== docker compose logs ===="
+ docker compose -f docker-compose-memcached-with-auth.yml logs || true
+
Review Comment:
There still seems to be a problem with the `bitnamisecure/memcached` image, but I haven't figured out exactly what's going on, the authentication doesn't seem to be reporting errors anymore, but the tests are timing out a ton!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org