You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@continuum.apache.org by Brett Porter <br...@apache.org> on 2006/09/18 16:06:47 UTC

Re: svn commit: r441469 - in /maven/continuum/branches/release-integration/maven/maven-release-plugin/src: main/java/org/apache/maven/plugins/release/ main/resources/META-INF/plexus/ test/resources/org/apache/maven/plugins/release/

On 08/09/2006, at 8:50 PM, epunzalan@apache.org wrote:

> Author: epunzalan
> Date: Fri Sep  8 03:50:09 2006
> New Revision: 441469
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=441469
> Log:
> PR: CONTINUUM-727
> +    private final int phaseSkip = 0, phaseStart = 1, phaseEnd = 2,  
> goalStart = 11, goalEnd = 12, error = 99;

Shouldn't these be constants? static PHASE_SKIP, PHASE_START, etc?

Re: svn commit: r441469 - in /maven/continuum/branches/release-integration/maven/maven-release-plugin/src: main/java/org/apache/maven/plugins/release/ main/resources/META-INF/plexus/ test/resources/org/apache/maven/plugins/release/

Posted by Edwin Punzalan <ep...@exist.com>.


I'll fix this asap.  Thanks.


Brett Porter wrote:
>
> On 08/09/2006, at 8:50 PM, epunzalan@apache.org wrote:
>
>> Author: epunzalan
>> Date: Fri Sep  8 03:50:09 2006
>> New Revision: 441469
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=441469
>> Log:
>> PR: CONTINUUM-727
>> +    private final int phaseSkip = 0, phaseStart = 1, phaseEnd = 2, 
>> goalStart = 11, goalEnd = 12, error = 99;
>
> Shouldn't these be constants? static PHASE_SKIP, PHASE_START, etc?
>