You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/08 06:51:33 UTC

[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36113: [SPARK-38107][SQL][FOLLOWUP] Refine the error-class name and message for grouped agg pandas UDF

HyukjinKwon commented on code in PR #36113:
URL: https://github.com/apache/spark/pull/36113#discussion_r845788900


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -22,8 +22,8 @@
   "CANNOT_UP_CAST_DATATYPE" : {
     "message" : [ "Cannot up cast %s from %s to %s.\n%s" ]
   },
-  "CANNOT_USE_MIXTURE" : {
-    "message" : [ "Cannot use a mixture of aggregate function and group aggregate pandas UDF" ]
+  "INVALID_PANDAS_UDF_PLACEMENT" : {
+    "message" : [ "The group aggregate pandas UDF %s cannot be invoked in the same SELECT list as other, non-pandas aggregate functions." ]

Review Comment:
   ```suggestion
       "message" : [ "The group aggregate pandas UDF %s cannot be invoked together with other, non-pandas aggregate functions." ]
   ```
   
   Since we have DataFrame API too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org