You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Thomas Heigl (Jira)" <ji...@apache.org> on 2020/08/30 18:52:00 UTC
[jira] [Commented] (WICKET-6824) Use concatenation instead of
String.format for frequently called methods
[ https://issues.apache.org/jira/browse/WICKET-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17187314#comment-17187314 ]
Thomas Heigl commented on WICKET-6824:
--------------------------------------
Created PR: https://github.com/apache/wicket/pull/449
> Use concatenation instead of String.format for frequently called methods
> ------------------------------------------------------------------------
>
> Key: WICKET-6824
> URL: https://issues.apache.org/jira/browse/WICKET-6824
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-core
> Affects Versions: 9.0.0
> Reporter: Thomas Heigl
> Assignee: Thomas Heigl
> Priority: Minor
> Attachments: image-2020-08-30-20-34-57-261.png, image-2020-08-30-20-35-04-970.png
>
>
> Two usages of {{String.format}} frequently show up in my production profiler:
> !image-2020-08-30-20-34-57-261.png!
> !image-2020-08-30-20-35-04-970.png!
> Both methods are potentially called dozens or even hundreds of times for large pages.
> {{String.format}} has horrible performance and should mostly be used for generating error messages and debug information. For a detailed analysis see: [https://redfin.engineering/java-string-concatenation-which-way-is-best-8f590a7d22a8]
> We should replace {{String.format}} with simple concatenation in both instances.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)