[GitHub] [kafka] dongjinleekr commented on a change in pull request #9930: MINOR: Fix always-passing validation in TestRecordTest#testProducerRecord

[GitBox <gi...@apache.org>]

dongjinleekr commented on a change in pull request #9930:
URL: https://github.com/apache/kafka/pull/9930#discussion_r574578473



##########
File path: streams/test-utils/src/test/java/org/apache/kafka/streams/test/TestRecordTest.java
##########
@@ -166,6 +166,9 @@ public void testProducerRecord() {
         final TestRecord<String, Integer> testRecord = new TestRecord<>(producerRecord);
         final TestRecord<String, Integer> expectedRecord = new TestRecord<>(key, value, headers, recordTime);
         assertEquals(expectedRecord, testRecord);
-        assertNotEquals(expectedRecord, producerRecord);
+        assertFalse(expectedRecord.getHeaders() == producerRecord.headers() &&

Review comment:
       > Is the assert intentional?
   
   It seems not. If it was interntional, the same statement must be included in its consumer-side counterpart test method, `testConsumerRecord`, which is actually not.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org