You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "homatthew (via GitHub)" <gi...@apache.org> on 2023/07/18 23:57:16 UTC

[GitHub] [gobblin] homatthew opened a new pull request, #3718: [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0

homatthew opened a new pull request, #3718:
URL: https://github.com/apache/gobblin/pull/3718

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [X] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   
   ### Description
   - [X] Here are some details about my PR, including screenshots (if applicable):
   HiveMetaStoreTest from Iceberg had some minor changes to the class that affect the order of metastore creation. This did not break our CI because iceberg tests run as a group in ABC order, so one of the tests was properly starting the metastore. But going forward, we should call the method and have an empty catch in case another test already init the hive metastore. 
   
   This would cause a NPE when the tests were run in isolation. 
   
   ### Tests
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   ![image](https://github.com/apache/gobblin/assets/35702680/acd8c3d5-7601-47db-94a6-cf8390a08ad6)
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] codecov-commenter commented on pull request #3718: [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3718:
URL: https://github.com/apache/gobblin/pull/3718#issuecomment-1641184110

   ## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3718?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#3718](https://app.codecov.io/gh/apache/gobblin/pull/3718?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bcb3ca3) into [master](https://app.codecov.io/gh/apache/gobblin/commit/2c2ffac77fed07bcc6486f9dee8cd60e41650ef7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2c2ffac) will **decrease** coverage by `1.81%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3718      +/-   ##
   ============================================
   - Coverage     46.79%   44.99%   -1.81%     
   + Complexity    10793     2121    -8672     
   ============================================
     Files          2143      412    -1731     
     Lines         84528    17821   -66707     
     Branches       9392     2171    -7221     
   ============================================
   - Hits          39557     8018   -31539     
   + Misses        41360     8943   -32417     
   + Partials       3611      860    -2751     
   ```
   
   
   [see 1733 files with indirect coverage changes](https://app.codecov.io/gh/apache/gobblin/pull/3718/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] ZihanLi58 merged pull request #3718: [GOBBLIN-1855] Metadata writer tests do not work in isolation after upgrading to Iceberg 1.2.0

Posted by "ZihanLi58 (via GitHub)" <gi...@apache.org>.
ZihanLi58 merged PR #3718:
URL: https://github.com/apache/gobblin/pull/3718


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org