You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/11/28 05:48:20 UTC

[GitHub] [guacamole-server] timgates42 opened a new pull request #313: docs: fix simple typo, verfying -> verifying

timgates42 opened a new pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313


   There is a small typo in src/libguac/tests/parser/read.c, src/libguac/tests/socket/fd_send_instruction.c, src/libguac/tests/socket/nested_send_instruction.c.
   
   Should read `verifying` rather than `verfying`.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] timgates42 commented on pull request #313: GUACAMOLE-1225: fix simple typo, verfying -> verifying, in code documentation

Posted by GitBox <gi...@apache.org>.
timgates42 commented on pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313#issuecomment-748779598


   Thanks @necouchman done now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] necouchman commented on pull request #313: docs: fix simple typo, verfying -> verifying

Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313#issuecomment-748615919


   Thanks, @timgates42 - I've corrected the title of the pull request, but you'll need to change the commit message to include "GUACAMOLE-1225: " at the beginning.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] timgates42 commented on pull request #313: docs: fix simple typo, verfying -> verifying

Posted by GitBox <gi...@apache.org>.
timgates42 commented on pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313#issuecomment-736413068


   Thanks @necouchman fixed now


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] timgates42 commented on pull request #313: docs: fix simple typo, verfying -> verifying

Posted by GitBox <gi...@apache.org>.
timgates42 commented on pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313#issuecomment-748353215


   The jira is https://issues.apache.org/jira/browse/GUACAMOLE-1225 - I've updated the commit message and PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] necouchman merged pull request #313: GUACAMOLE-1225: fix simple typo, verfying -> verifying, in code documentation

Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [guacamole-server] necouchman commented on pull request #313: docs: fix simple typo, verfying -> verifying

Posted by GitBox <gi...@apache.org>.
necouchman commented on pull request #313:
URL: https://github.com/apache/guacamole-server/pull/313#issuecomment-735229474


   @timgates42 Thank you for catching this and fixing it.
   
   However, any/all changes to code, including documentation typo fixes, require a JIRA issue (https://issues.apache.org/jira/browse/GUACAMOLE) and tagging of that issue in the pull request and commit message(s). If you can open a JIRA issue and then tag everything appropriately I think we can probably get this one merged rather quickly!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org