You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/18 07:40:54 UTC

[GitHub] [nifi] pvillard31 commented on a change in pull request #4826: NIFI-5623 Upgraded OkHttp to 4.9.1 and updated unit tests

pvillard31 commented on a change in pull request #4826:
URL: https://github.com/apache/nifi/pull/4826#discussion_r578192600



##########
File path: nifi-nar-bundles/nifi-standard-services/nifi-oauth2-provider-bundle/nifi-oauth2-provider-service/pom.xml
##########
@@ -74,7 +74,7 @@
         <dependency>
             <groupId>com.squareup.okhttp3</groupId>
             <artifactId>okhttp</artifactId>
-            <version>3.14.4</version>
+            <version>${okhttp.version}</version>

Review comment:
       Any reason to use the "externalized" version for NiFi framework here but not for the other bundles? The OAuth2 bundle is not part of the framework pieces I believe.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org