You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bobu-putheeckal (via GitHub)" <gi...@apache.org> on 2026/05/24 20:46:03 UTC
[PR] Persist DAG list filters across navigation [airflow]
bobu-putheeckal opened a new pull request, #67442:
URL: https://github.com/apache/airflow/pull/67442
closes: #66933
DAG list status, last run state, favorites, and required-action filters now fall back to page-scoped localStorage when the URL does not carry those params. URL params still take precedence, and changing a filter keeps the existing URL behavior while saving the selection for later in-app navigation back to `/dags`.
### Tests
- `NODE_OPTIONS=--no-experimental-webstorage npx --yes pnpm@10 test src/pages/DagsList/useDagsFilterParams.test.tsx src/pages/DagsList/DagsList.test.tsx src/pages/DagsList/DagsFilters/DagsFilters.test.tsx`
- `npx --yes pnpm@10 exec tsc --p tsconfig.app.json --noEmit`
- `npx --yes pnpm@10 exec eslint src/constants/localStorage.ts src/pages/DagsList/useDagsFilterParams.ts src/pages/DagsList/useDagsFilterParams.test.tsx src/pages/DagsList/DagsList.tsx src/pages/DagsList/DagsList.test.tsx src/pages/DagsList/DagsFilters/DagsFilters.tsx src/pages/DagsList/DagsFilters/DagsFilters.test.tsx`
Note: the focused Vitest run prints existing MSW bypass ECONNREFUSED noise for localhost:3000, but exits green. On Node 25 I had to disable experimental web storage so happy-dom localStorage works; baseline `useTagFilter` has the same requirement in this environment.
---
##### Was generative AI tooling used to co-author this PR?
- [x] Yes (GPT-5 Codex)
Generated-by: GPT-5 Codex following the guidelines at https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #67442:
URL: https://github.com/apache/airflow/pull/67442#issuecomment-4529945815
Screenshots please!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "bobu-putheeckal (via GitHub)" <gi...@apache.org>.
bobu-putheeckal commented on PR #67442:
URL: https://github.com/apache/airflow/pull/67442#issuecomment-4530757020
Thanks, agreed. I rewrote the PR description with the concrete problem/fix/tests and am moving this to draft until I can add before/after screenshots or a short GIF showing DAG list filters persisting across navigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "pedro-cf (via GitHub)" <gi...@apache.org>.
pedro-cf commented on PR #67442:
URL: https://github.com/apache/airflow/pull/67442#issuecomment-5059863995
> Yes I think we can close this one as it seems stale. I plan on implementing something similar, to persist 'named' views.
If possible relate to this issue https://github.com/apache/airflow/issues/66933 thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #67442:
URL: https://github.com/apache/airflow/pull/67442#issuecomment-4662229806
@bobu-putheeckal any progress? Would love to try to get this in for 3.3 if possible. Otherwise I think @pierrejeambrun was thinking about taking this feature on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #67442:
URL: https://github.com/apache/airflow/pull/67442#issuecomment-4597714960
This pull request has been automatically marked as stale because the author has not responded to a request for more information. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #67442:
URL: https://github.com/apache/airflow/pull/67442#issuecomment-4671059585
Yes I think we can close this one as it seems stale. I plan on implementing something similar, to persist 'named' views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Persist DAG list filters across navigation [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun closed pull request #67442: Persist DAG list filters across navigation
URL: https://github.com/apache/airflow/pull/67442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org