You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/17 11:02:35 UTC

[GitHub] [echarts] plainheart opened a new pull request, #17934: fix(dataZoom): fallback to extent start/end when parsed value or percent is invalid.

plainheart opened a new pull request, #17934:
URL: https://github.com/apache/echarts/pull/17934

   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix the `dataZoom` can't render when `start/end/startValue/endValue` doesn't exist in the axis categories or is invalid value. 
   
   ### Fixed issues
   
   N.A.
   
   ## Details
   
   ### Before: What was the problem?
   
   <img src="https://user-images.githubusercontent.com/26999792/202427811-7b79c138-af54-4ed7-86fc-139e830851c2.png" width="400">
   
   ### After: How does it behave after the fixing?
   
   Fallback to extent start/end when parsed value or percent is invalid.
   
   <img src="https://user-images.githubusercontent.com/26999792/202427898-80809cbb-526f-4ca2-95fd-e36fbecd157a.png" width="400">
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to the 4th case in `test/axis-lastLabel.html` 
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17934: fix(dataZoom): fallback to extent start/end when parsed value or percent is invalid.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17934:
URL: https://github.com/apache/echarts/pull/17934#issuecomment-1318471010

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart merged pull request #17934: fix(dataZoom): fallback to extent start/end when parsed value or percent is invalid.

Posted by GitBox <gi...@apache.org>.
plainheart merged PR #17934:
URL: https://github.com/apache/echarts/pull/17934


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17934: fix(dataZoom): fallback to extent start/end when parsed value or percent is invalid.

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17934:
URL: https://github.com/apache/echarts/pull/17934#issuecomment-1318463484

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org